[diffs] External vs Internal Edit Hardening - #1072
Draft
amadeus wants to merge 25 commits into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Also ensure things like hydration and stuff were setup properly in the new world
Something of a sidequest, but the main thing here was to really harden how an external vs rendered diff is handled, and ensure especially in virtualized environments that we don't create really bad layout mismatches.
This was what we've been working towards, and it seems pretty great!
Cache keys were required there
Also found a few areas where FileDiff did dumb shit that could also be cleaned up
* Added File and Diff normal variants to playground * Added comment/line selection modes to normal Virtualizers
amadeus
force-pushed
the
amadeus/external-edit-hardening
branch
from
August 12, 2026 21:52
bb929e9 to
72f6950
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a big PR, but I think it's mostly working to pay down some technical debt from the edit launch.
A big drive of thise PR is to make Files and Diffs follow a similar update/render architecture.
I'll need to write up more later with details about how all of this works.