Skip to content

fix: various issues fixed - #4

Merged
aensidhe merged 41 commits into
picodata-masterfrom
fix/review-findings-pass3
Sep 29, 2026
Merged

fix: various issues fixed#4
aensidhe merged 41 commits into
picodata-masterfrom
fix/review-findings-pass3

Conversation

@aensidhe

@aensidhe aensidhe commented Sep 28, 2026

Copy link
Copy Markdown
Member

No description provided.

@aensidhe
fix: send upsert with the UPSERT opcode
1410934 
Signed-off-by: Anatoly Popov <me@aensidhe.ru>
@aensidhe
fix: encode DmoOperation::insert with the ! operator
e618633 
Signed-off-by: Anatoly Popov <me@aensidhe.ru>
@aensidhe
fix: keep the writer queue non-empty for small request thresholds
0d2d90f 
Signed-off-by: Anatoly Popov <me@aensidhe.ru>
@aensidhe
fix: bound error description length by the remaining frame bytes
abe74c6 
Signed-off-by: Anatoly Popov <me@aensidhe.ru>
@aensidhe
fix: decode a frame length as soon as it is fully received
1c768ef 
Signed-off-by: Anatoly Popov <me@aensidhe.ru>
@aensidhe
fix: keep the last salt character and accept padded or unpadded base64
a6bbf68 
Signed-off-by: Anatoly Popov <me@aensidhe.ru>
@aensidhe
fix: pass connect_timeout rather than the request timeout to the disp…
dab7f8a 
…atcher

Signed-off-by: Anatoly Popov <me@aensidhe.ru>
@aensidhe
fix: wrap the request sync counter instead of overflowing
de7283f 
Signed-off-by: Anatoly Popov <me@aensidhe.ru>
@aensidhe
fix: report a failed writer task join as a connection error
30380bd 
Signed-off-by: Anatoly Popov <me@aensidhe.ru>
@aensidhe
fix: reject an auth response whose sync does not match the request
8649b04 
Signed-off-by: Anatoly Popov <me@aensidhe.ru>
@aensidhe
fix: skip preparing SQL statements while another prepare is in flight
7f41b26 
Signed-off-by: Anatoly Popov <me@aensidhe.ru>
@aensidhe
fix: drop the partial frame when request encoding fails
af38d01 
Signed-off-by: Anatoly Popov <me@aensidhe.ru>
@aensidhe
docs: correct the SQL cache default and drop the orphan call response…
80622f6 
… file

Signed-off-by: Anatoly Popov <me@aensidhe.ru>
@aensidhe
refactor: remove the dead resend machinery
faff9f6 
Signed-off-by: Anatoly Popov <me@aensidhe.ru>
@aensidhe
feat: fail stale streams and transactions after reconnect
1474168 
Signed-off-by: Anatoly Popov <me@aensidhe.ru>
@aensidhe
fix: evict timed-out requests from the in-flight map
e452dff 
Signed-off-by: Anatoly Popov <me@aensidhe.ru>
@aensidhe
fix: stop reconnecting once the last client handle is gone
161403f 
Signed-off-by: Anatoly Popov <me@aensidhe.ru>
@aensidhe
fix: never send a second rollback for a finished transaction
349ced8 
Signed-off-by: Anatoly Popov <me@aensidhe.ru>
@aensidhe
fix: warn about a disabled reconnect interval and fix UniqueIdNameMap…
c6cb82f 
… nits

Signed-off-by: Anatoly Popov <me@aensidhe.ru>
@aensidhe
fix: invalidate the SQL statement cache after a reconnect
00e9b16 
Signed-off-by: Anatoly Popov <me@aensidhe.ru>
@aensidhe
chore: ignore the repo-local tmp directory
777272a 
Signed-off-by: Anatoly Popov <me@aensidhe.ru>
@aensidhe
ci: follow the plugin template lint gates and fix the audit
dda167c 
Signed-off-by: Anatoly Popov <me@aensidhe.ru>
@aensidhe
fix: accept any u32 response frame and reject requests over 2 GiB
7015a34 
Signed-off-by: Anatoly Popov <me@aensidhe.ru>
@aensidhe
fix: carry 64-bit syncs end to end
be81d62 
Signed-off-by: Anatoly Popov <me@aensidhe.ru>
@aensidhe
fix: pipeline AUTH and ID and drop the unread feature state
9b73334 
Signed-off-by: Anatoly Popov <me@aensidhe.ru>
@aensidhe
perf: batch writer flushes and stop the writer by abort
38ae108 
Signed-off-by: Anatoly Popov <me@aensidhe.ru>
@aensidhe
fix: cancel every dropped request through a dedicated channel
7381544 
Signed-off-by: Anatoly Popov <me@aensidhe.ru>
@aensidhe
fix: close the connection when the last handle drops
176f64c 
Signed-off-by: Anatoly Popov <me@aensidhe.ru>
@aensidhe
fix: advance the generation as soon as a connection is lost
48de993 
Signed-off-by: Anatoly Popov <me@aensidhe.ru>
@aensidhe
feat: hand the transaction back when commit or rollback fails on the …
48b8b67 
…client

Signed-off-by: Anatoly Popov <me@aensidhe.ru>
@aensidhe
fix: keep the drop-time rollback from holding the connection alive
9dad7ca 
Signed-off-by: Anatoly Popov <me@aensidhe.ru>
@aensidhe
fix: guard the SQL statement cache by generation and evict rejected ids
72f8519 
Signed-off-by: Anatoly Popov <me@aensidhe.ru>
@aensidhe
fix: bound connection setup, clamp the threshold and normalize the ba…
cdefcff 
…ckoff

Signed-off-by: Anatoly Popov <me@aensidhe.ru>
@aensidhe
fix: give DmoOperation::delete a count and return nothing from upsert
01d2e91 
Signed-off-by: Anatoly Popov <me@aensidhe.ru>
@aensidhe
refactor: use testcontainers' ImageExt helpers in the test container
aecadb1 
Signed-off-by: Anatoly Popov <me@aensidhe.ru>
@aensidhe
build: check the minimum dependency versions with a dated nightly
c3389b7 
Signed-off-by: Anatoly Popov <me@aensidhe.ru>
@aensidhe
fix: send no PREPARE through a finished transaction or a stale stream
a548ad0 
Signed-off-by: Anatoly Popov <me@aensidhe.ru>
@aensidhe
test: pin the handshake, writer and dispatcher edge cases
7e6a4d9 
Signed-off-by: Anatoly Popov <me@aensidhe.ru>
@aensidhe
test: reach the outage in the outage tests and commit as an authentic…
1ed33a3 
…ated user

Signed-off-by: Anatoly Popov <me@aensidhe.ru>
@aensidhe
fix: spell transaction correctly in logs and docs
b406b5f 
Signed-off-by: Anatoly Popov <me@aensidhe.ru>
@aensidhe
docs: add changelog entries for the review fixes
9c9fb5d 
Signed-off-by: Anatoly Popov <me@aensidhe.ru>
@aensidhe aensidhe mentioned this pull request Sep 28, 2026
Closed
@aensidhe
aensidhe changed the base branch from master to picodata-master September 28, 2026 09:22
@aensidhe
aensidhe merged commit 9c9fb5d into picodata-master Sep 29, 2026
12 checks passed
@aensidhe
aensidhe deleted the fix/review-findings-pass3 branch September 29, 2026 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@aensidhe