Repository navigation
Conversation
alrsorokin
reviewed
Oct 19, 2026
| const ENV_PICODATA_PATH: &str = "PICODATA_PATH"; | ||
| const ENV_TOPOLOGY_PATH: &str = "TOPOLOGY_PATH"; | ||
|
|
||
| pub fn use_release_build() -> bool { |
Collaborator
There was a problem hiding this comment.
выбирать режим debug / release не должен управляться извне
надо бы перенести в picotest_helpers и вызывать use_release при создании кластера в new как дефолтное поведение
| let picodata_admin = Command::new("picodata") | ||
| .arg("admin") | ||
| .arg(self.socket_path.clone()) | ||
| .arg(self.socket_path.file_name().unwrap()) |
Collaborator
There was a problem hiding this comment.
еще вероятно file_name тут всегда admin.sock, для которой у нас есть константа ADMIN_SOCKET_NAME
тогда нам необходимо в impl From for PicotestInstance сохранять socket_dir
в таком случае должны полностью избавиться от unwrap
| self | ||
| } | ||
|
|
||
| pub fn use_release(mut self, is_enabled: bool) -> Self { |
Collaborator
There was a problem hiding this comment.
после переноса поиска профиля можно будет удалить, не вижу кейсов для смены сборки в процессе тестирования
danilasar
force-pushed
the
dgrigorev/release-build
branch
from
October 22, 2026 12:15
54a31bf to
d47f246
Compare
danilasar
force-pushed
the
dgrigorev/release-build
branch
from
October 23, 2026 20:11
d47f246 to
1c1e6a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #275