Repository navigation
Conversation
- Add isApplyingLongRunningFilter state tracking in gallery viewer - Display captured image with 'Filter is processing...' overlay during long-running processing - Implement 500ms cross-fade transition into final filtered image - Update state store and API DTOs for long-running filter metadata - Add i18n translations for 'Filter is processing...'
… long-running gallery filters
…k processing pill badge
…d gallery filter updating
…ng-running action results
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: rainbow loading effect and smooth fade transitions for filter processing
To make the wait for AI (or other long running) filters more enjoyable, this PR introduces two UX improvements:
Rainbow loading indicator
A rainbow-colored border animates around the image while a long-running filter (e.g. AI filters) is being processed. This only activates when a plugin identifies itself as long-running via the new
mp_long_running_filterhook — it does not affect existing regular filter plugins. For long-running actions in the gallery, a translucent overlay "Filter is processing..." is shown and the top progress bar is hidden to keep the experience clean.This relies on the new jobmodels added in photobooth-app PR:
latest_caputre_idto display the original capture of the image during the effectis_long_running_filterfrom photobooth-app PR to determine if it is indeed a long running filter.Smooth fade transitions
To avoid filtered images snapping abruptly into place, a 1-second cross-fade transition is applied when presenting processed results. The fade is also used when updating gallery items after a filter is applied, but instead of reverting back to the original image, it shortly fades to black before showing new image.
Related: photobooth-app PR
support long-running filter hook and export metadata to frontend- photobooth-app/photobooth-app#781AI used to create this Pull Request?
Yes — this PR was written with assistance of AI but screened and tested by myself.