Skip to content

fix: resolve sonarqube security findings #1373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ron (rjaegers) merged 12 commits into from
Jul 21, 2026
Merged

fix: resolve sonarqube security findings #1373

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
2b31dc5
fix: resolve sonarqube security findings
rjaegers Jul 21, 2026
a1c077b
chore: fix sonarqube findings differently
rjaegers Jul 21, 2026
61a09cd
ci: de-duplicate env
rjaegers Jul 21, 2026
2975c4c
chore: forgot one wget
rjaegers Jul 21, 2026
2e763b5
fix(docker:S6570): double quote to prevent globbing and word splitting
rjaegers Jul 21, 2026
18ad7b4
chore: remove false sense of security
rjaegers Jul 21, 2026
4c4a5e3
chore: fix incorrect add url
rjaegers Jul 21, 2026
99227e7
chore: add signature files
rjaegers Jul 21, 2026
f83410a
ci: fix arg propagation
rjaegers Jul 21, 2026
30d839e
chore: get rid of another wget
rjaegers Jul 21, 2026
adb10ee
chore: add missing line-continuation
rjaegers Jul 21, 2026
a1a9077
chore: get rid of another wget
rjaegers Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .devcontainer/cpp/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ RUN --mount=from=downloader,target=/dl \
ARM_GNU_TOOLCHAIN_SHA256="d061559d814b205ed30c5b7c577c03317ec447ca51cd5a159d26b12a5bbeb20c"
fi

wget --no-hsts -qO "${ARM_GNU_TOOLCHAIN_TAR}" "${ARM_GNU_TOOLCHAIN_URL}"
wget --no-hsts --max-redirect=0 -qO "${ARM_GNU_TOOLCHAIN_TAR}" "${ARM_GNU_TOOLCHAIN_URL}"
Comment thread
rjaegers marked this conversation as resolved.
Outdated
echo "${ARM_GNU_TOOLCHAIN_SHA256} ${ARM_GNU_TOOLCHAIN_TAR}" | sha256sum -c -

tar xJf "${ARM_GNU_TOOLCHAIN_TAR}" --exclude="*arm-none-eabi-gdb*" --exclude="share"
Expand Down Expand Up @@ -157,7 +157,7 @@ RUN --mount=type=bind,source=.devcontainer/cpp/apt-requirements-base.json,target

# Install include-what-you-use (iwyu) from source
apt-get update && apt-get install -y --no-install-recommends libclang-${CLANG_VERSION}-dev llvm-${CLANG_VERSION}-dev
wget --no-hsts -qO - https://github.com/include-what-you-use/include-what-you-use/archive/refs/tags/${INCLUDE_WHAT_YOU_USE_VERSION}.tar.gz | tar xz -C /tmp
wget --no-hsts --max-redirect=0 -qO - https://github.com/include-what-you-use/include-what-you-use/archive/refs/tags/${INCLUDE_WHAT_YOU_USE_VERSION}.tar.gz | tar xz -C /tmp
Comment thread
rjaegers marked this conversation as resolved.
Outdated
CC=clang CXX=clang++ cmake -S /tmp/include-what-you-use-${INCLUDE_WHAT_YOU_USE_VERSION} -B /tmp/include-what-you-use-${INCLUDE_WHAT_YOU_USE_VERSION}/build
cmake --build /tmp/include-what-you-use-${INCLUDE_WHAT_YOU_USE_VERSION}/build --target install
rm -rf /tmp/include-what-you-use-${INCLUDE_WHAT_YOU_USE_VERSION}
Expand Down Expand Up @@ -189,7 +189,7 @@ RUN --mount=type=bind,source=.devcontainer/cpp/apt-requirements-base.json,target
# CMake module (not an ELF binary), so it cannot carry a `.note.package` ELF
# section and Syft has no cataloger for standalone `.cmake` files. Its version is
# pinned and tracked via the CPM_VERSION build argument above.
wget --no-hsts -qP /usr/local/lib/python*/dist-packages/cmake/data/share/cmake-*/Modules/ https://github.com/cpm-cmake/CPM.cmake/releases/download/v${CPM_VERSION}/CPM.cmake
wget --no-hsts --max-redirect=0 -qP /usr/local/lib/python*/dist-packages/cmake/data/share/cmake-*/Modules/ https://github.com/cpm-cmake/CPM.cmake/releases/download/v${CPM_VERSION}/CPM.cmake
Comment thread
rjaegers marked this conversation as resolved.
Outdated
conan profile detect
echo -e "\n[conf]\ntools.cmake.cmaketoolchain:generator=Ninja" >> "$(conan profile path default)"

Expand Down
2 changes: 1 addition & 1 deletion .devcontainer/rust/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ RUN --mount=type=bind,source=.devcontainer/rust/apt-requirements.json,target=/tm
rustup target add thumbv7em-none-eabihf
fi

wget -qO - "https://github.com/cargo-bins/cargo-binstall/releases/download/v${CARGO_BINSTALL_VERSION}/cargo-binstall-$(uname -m)-unknown-linux-gnu.tgz" | tar xz -C "/usr/bin"
wget --no-hsts --max-redirect=0 -qO - "https://github.com/cargo-bins/cargo-binstall/releases/download/v${CARGO_BINSTALL_VERSION}/cargo-binstall-$(uname -m)-unknown-linux-gnu.tgz" | tar xz -C "/usr/bin"
Comment thread
rjaegers marked this conversation as resolved.
Outdated
cargo-binstall -y --locked "cargo-binutils@${CARGO_BINUTILS_VERSION}" \
"cargo-mutants@${CARGO_MUTANTS_VERSION}"

Expand Down
2 changes: 1 addition & 1 deletion .github/actions/container-size-diff/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ runs:
cache-dependency-path: package.json
node-version: 22.x

- run: npm install
- run: npm install --ignore-scripts
shell: bash

- uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/wc-acceptance-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ jobs:
- uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 24.8.0
- run: npm ci
- run: npm ci --ignore-scripts
- run: npx playwright install --with-deps
- name: Wait for Codespace to be active
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/wc-build-push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ jobs:
CONTAINER: ${{ needs.sanitize-image-name.outputs.fully-qualified-image-name }}:${{ steps.metadata.outputs.version }}
- run: |
set -Eeuo pipefail
wget -O diffoci https://github.com/reproducible-containers/diffoci/releases/download/v0.1.7/diffoci-v0.1.7.linux-amd64
wget --max-redirect=0 -qO diffoci https://github.com/reproducible-containers/diffoci/releases/download/v0.1.8/diffoci-v0.1.8.linux-amd64
Comment thread
rjaegers marked this conversation as resolved.
Outdated
chmod +x diffoci
./diffoci diff --semantic --report-file=container-diff.json "${FROM_CONTAINER}" "${TO_CONTAINER}" || true
env:
Expand Down
Loading