Fix isActiveProcess deprecation and repoint Mocketry to v7.0.4 - #9
Open
oliveiraallex wants to merge 1 commit into
Open
oliveiraallex wants to merge 1 commit into
oliveiraallex wants to merge 1 commit into
Conversation
- BasysConnection>>close: use isActive instead of deprecated isActiveProcess - BaselineOfBasys: repoint Mocketry to github://dionisiydk/Mocketry:v7.0.4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On Pharo 13,
Process>>isActiveProcessis deprecated and redirects toProcess>>isActive; the deprecation warning isn't auto-resumed in non-interactive contexts, soBasysConnection>>closenever completed and connections were left open but never properly closed.The baseline stillpointed at an incompatible Mocketry tag, which this PR also fixes.
Changes
BasysConnection>>close: replace deprecatedProcess>>isActiveProcesswithProcess>>isActive.BaselineOfBasys: repointMocketrydependency fromv7.0.2tov7.0.4(target tag of the Pharo 13 dependency chain, compatible withStateSpecs v5.0.4), referencied on: Update BaselineOfSeamless dependency pointers for Pharo 13 Seamless#56