Repository navigation
i18n: translate the remaining French strings in uvault status - #3
Merged
Merged
Conversation
`uvault status` mixes French into otherwise English output:
├─ Statut : 🔵 PullRequestStatus.ACTIVE
└─ Update : à jour (dernière activité il y a 4 mois)
and "Force-Push detecté!" in the inline and table renderers. The README,
docs, CLI help and every other message are English, so this reads as an
oversight rather than a choice.
Translated the eleven affected strings and updated the assertions in
tests/test_status.py. No behaviour change; 100% coverage preserved.
├─ Status : 🔵 PullRequestStatus.ACTIVE
└─ Update : up to date (last activity 4 month(s) ago)
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Pierre, thanks for
uvault, and for the OCA Days talk that pointed me at it. We're evaluating it at OBS Solutions for a ~60-dependency Odoo project, and these are two small things we hit on day one. Sending them as separate PRs so you can take either independently.What
uvault statusmixes French into otherwise English output:plus
Force-Push detecté!in the inline and table renderers, andinconnue/aujourd'huifrom_format_date.The README, docs, CLI help and every other message are English, so I've assumed this is an oversight.
After
Notes
status.py; assertions intests/test_status.pyupdated to match.Statut→Statusas the only alignment-affecting change; the box-drawing columns still line up.