test: ds-shots verification — DO NOT MERGE (TASK-22044) - #2910
test: ds-shots verification — DO NOT MERGE (TASK-22044)#2910kushagrasarathe wants to merge 1 commit into
Conversation
Throwaway verification PR for the merged ds-shots changes (report artifact + 2-width capture + build cache). Never to be merged — closed once the run is inspected. TASK-22044
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Code-analysis diffPainscore total: 7153.05 → 7153.15 (+0.1) |
🧪 UI test report — ✅ all greenSuites
📊 Coverage (unit)
⏱ 10 slowest test cases
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
There was a problem hiding this comment.
Chip review — no blocking findings — this is not an approval
Clean for the stated throwaway verification purpose: the sole change nudges only the settings-language fixture by 8px. The PR should remain unmerged as its description states.
Checked clean
- Correctness: pt-4 to pt-6 uses the repository's stock 4px spacing scale, producing the intended 8px vertical shift.
- Scope and adversarial paths: LanguageView serves /settings/language and is registered as the settings-language fixture; no logic, state, authorization, or data path changed.
- Security and slop: the existing utility-class replacement adds no trust-boundary, dependency, duplication, dead-code, or architecture change.
- CI at the exact head: every completed required gate passed, including unit, typecheck, eslint, format, ds-lint, ds-shots-filter, analyze, and ci-success; ds-shots was still in progress when reviewed.
Second opinion by moonshotai/kimi-k3: 0 finding(s), marked with the model name. It reads the diff only, so treat its findings as advice.
Third opinion by claude-opus: 0 finding(s), marked with the model name. It answers only product truth, missing tests and the cross-repo contract, so treat its findings as advice.
Exact head: 4cddecfc7184 · Context: repo · Took 3m (queued 6m)
🖼 Visual diff — 2 screens moved5 of 120 shots changed · 115 identical · baseline
job summary · before/after/diff images — artifact Fixture screenshots, no backend. Advisory — this check never blocks a merge. Posted from the default branch by ds-shots-comment.yml; the report it renders is untrusted data. |
Throwaway verification PR for the ds-shots changes merged in #2897 and #2907. It nudges the
settings-languagescreen 8px so exactly one fixture moves.Expected on this PR's Tests run:
visual-diff-report-<pr#>-1(small, baseline SHA stamped) andvisual-diff-<pr#>-1(PNGs)settings-language@320/430changed, everything else identical, no removed-width noisescripts/ds-shots-publish.mjsagainst the report renders the sticky comment the publisher will post once the workflow reaches main (workflow_run fires from the default branch only — the comment itself CANNOT appear on this PR yet, that is the documented deploy gotcha)This PR is never merged. It gets closed after the run is inspected and the branch deleted.
Screenshots: N/A (throwaway test change).