Remove SHA384 and SHA512 - #7
Draft
DanGould wants to merge 1 commit into
Draft
Conversation
DanGould
force-pushed
the
rm-sha-384-512
branch
from
August 14, 2024 19:06
81ab901 to
b458e5f
Compare
Bitcoin HPKE apps don't use them, although SHA512 is used in BIP32 derivation.
DanGould
force-pushed
the
rm-sha-384-512
branch
from
August 14, 2024 19:07
b458e5f to
1fda5a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bitcoin apps don't use them.
This removes some maintenance burden, but is fully supported by
bitcoin_hashesif we wanted to add it back.Well, sha512 is used in BIP32 derivation but not in HPKE.
Not sure if this is necessary, but imo less code is better.