Repository navigation
Conversation
OBU-padding breaks browser playback
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello.
OBU-padding breaks playback on both chrome and firefox, there is currently a patch to fix this for libwebrtc (but it's not merged yet): https://webrtc-review.googlesource.com/c/src/+/503960
I have been trying to track this problem for a while I noticed that it happens for me with OBS+NVENC on CBR mode but other users reported that it happens on VBR mode too: Glimesh/broadcast-box#633 (comment)
We patched it at Pion pion/rtp#373 but I'm not sure if you're open to merge this filter since the spec doesn't require it and it seems to be a browser issue. It shouldn't cause playback issues if you wish to merge it (might affect BWE but it's better than no playback I think).
edit: more details here https://bugzilla.mozilla.org/show_bug.cgi?id=2017189#c23