Skip to content

Add support for BigDecimal parsing #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Antsiscool wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add support for BigDecimal parsing #78

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10159d2
Add support for BigDecimal parsing
Antsiscool Jan 9, 2018
ccc11c2
Remove deprecated use of BigDecimal#new
Antsiscool Jan 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/sax-machine/handlers/sax_abstract_handler.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ def _start_element(name, attrs = [])
case element_config.data_class.to_s
when "Integer" then 0
when "Float" then 0.0
when "BigDecimal" then BigDecimal.new("0.0")

@HParker HParker Sep 3, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this change is from a while ago, but the API changed to BigDecimal("0.0") Ruby change

when "Symbol" then nil
when "Time" then Time.at(0)
when "" then object
Expand Down Expand Up @@ -180,6 +181,7 @@ def data_class_value(data_class, value)
when "String" then value != NO_BUFFER ? value.to_s : value
when "Integer" then value != NO_BUFFER ? value.to_i : value
when "Float" then value != NO_BUFFER ? value.to_s.gsub(",",".").to_f : value
when "BigDecimal" then value != NO_BUFFER ? BigDecimal.new(value.to_s.gsub(",",".")) : value
when "Symbol" then
if value != NO_BUFFER
value.to_s.empty? ? nil : value.to_s.downcase.to_sym
Expand Down
34 changes: 34 additions & 0 deletions spec/sax-machine/sax_document_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,40 @@ class TestFloatWithAttribute
end
end

describe "big decimal" do
before do
class TestBigDecimal
include SAXMachine
element :number, class: BigDecimal
end

class TestBigDecimalAttribute
include SAXMachine
attribute :sub_number, class: BigDecimal
end

class TestBigDecimalWithAttribute
include SAXMachine
element :number, class: TestBigDecimalAttribute
end
end

it "is handled in an element with '.' delimiter" do
document = TestBigDecimal.parse("<number>3.0000000000000021</number>")
expect(document.number).to eq(BigDecimal.new('3.0000000000000021'))
end

it "is handled in an element with ',' delimiter" do
document = TestBigDecimal.parse("<number>3,0000000000000021</number>")
expect(document.number).to eq(BigDecimal.new('3.0000000000000021'))
end

it "is handled in an attribute" do
document = TestBigDecimalWithAttribute.parse("<number sub_number='3.0000000000000021'>3.0000000000000021</number>")
expect(document.number.sub_number).to eq(BigDecimal.new('3.0000000000000021'))
end
end

describe "symbol" do
before do
class TestSymbol
Expand Down