Repository navigation
Conversation
… lane e2e-app.yml has run the same driver with the same flag as its last lane (`e2e-app.sh --no-build --crash-recovery`, not continue-on-error) every night since the lane was added there, and on every push to main. The 06:15 UTC schedule of e2e-crash-recovery.yml therefore ran the same assertions a second time against the same commit on the one self-hosted machine, about ten minutes per night for no new evidence. The reason its header gave for a separate nightly, that the SIGKILL and relaunch would disrupt e2e-app's other lanes, no longer described the setup: the e2e-app step runs after every other lane for exactly that reason. The header now says where the automatic coverage comes from. The workflow keeps its dispatch and run-e2e label triggers, which run the lane alone on a fresh build of its own. No required check, ruleset or doc references the schedule.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #973 +/- ##
=======================================
- Coverage 91.9% 91.9% -0.1%
=======================================
Files 317 317
Lines 24317 24317
Branches 6 6
=======================================
- Hits 22356 22355 -1
- Misses 1957 1958 +1
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
e2e-crash-recovery.ymlran every night at 06:15 UTC.e2e-app.ymlalready runs the same driver with the same flag (e2e-app.sh --no-build --crash-recovery) as its last lane, every night, on every push to main and on therun-e2elabel, and that step is notcontinue-on-error. The standalone schedule therefore repeated the same assertions against the same commit on the one self-hosted machine, about ten minutes per night for no new evidence.This removes only the
schedule:trigger. The workflow keepsworkflow_dispatchand therun-e2elabel trigger, where it runs the lane alone on a fresh build of its own. Its header gave a reason for the separate nightly (the SIGKILL and relaunch would disrupt the other lanes ofe2e-app) that no longer described the setup, because thee2e-appstep runs after every other lane for exactly that reason; the header and the comment on thee2e-appstep now say where the automatic coverage comes from.Deliberately not changed
e2e-channel-fault.ymlalso has its own nightly slot (05:45 UTC) next to a step ine2e-app.yml, but that is not a duplicate: thee2e-appstep iscontinue-on-error: true, so a regression there leaves the run green, and the standalone workflow is the only nightly that turns red. Removing its schedule would lose that signal.Tests
actionlinton both edited workflows: no findings beyond theaudiorunner label it does not know, which main reports as well.scripts/tests/test_*.shpass.AI assistance
Written with Claude (Opus 5.5): the comparison of the two lanes, the change and the commit message. Reviewed and re-verified locally with Claude (Fable 5.2): diff and both call sites read, workflow lint and script tests repeated.
Checklist
scripts/tests/test_*.sh