chore: update subxt to 0.51.0 and drop the v4 extension version workaround - #415
Merged
Merged
Conversation
…round subxt 0.51.0 carries the upstream fix from paritytech/subxt#2277, so `extrinsic_extension_info(None)` now resolves to transaction extension version 0 for v4 extrinsics rather than the newest version in the metadata. `V4CompatMetadata` existed only to correct that, so it goes. frame-decode moves to 0.18.1 alongside, since subxt 0.51 builds against it and the `ExtrinsicTypeInfo` implementation we decode through has to come from the same version. `DecodedExtrinsic` and `fetch_block_body` stay. They are not about the extension version; subxt still keeps the raw bytes of each block body entry private, which is what lets us report an undecodable extrinsic at its own index and log the bytes that failed. The test that pinned the old upstream behaviour now asserts the fix instead, so a regression on a future bump fails here rather than quietly dropping extrinsics from block responses.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: nothing, follow up to #406.
Description
subxt 0.51.0 carries the upstream fix from paritytech/subxt#2277, so
extrinsic_extension_info(None)now resolves to transaction extension version 0 for a v4 extrinsic rather than the newest version in the metadata.V4CompatMetadataexisted only to correct that, so it goes.frame-decode moves to 0.18.1 alongside it. subxt 0.51 builds against that version, and the
ExtrinsicTypeInfoimplementation we decode through has to come from the same one.0.51.0 is a breaking release upstream, but only for signing:
DefaultTransactionExtensionsandDefaultExtrinsicParamsbecame structs. This service never builds or signs a transaction, so nothing here needed changing.Changes
DecodedExtrinsicandfetch_block_bodystay. They were never about the extension version. subxt still keeps the raw bytes of each block body entry private, and that is what lets us report an undecodable extrinsic at its own index and log the bytes that failed.The test that pinned the old upstream behaviour now asserts the fix instead, so a regression on some future bump fails there rather than quietly dropping extrinsics from block responses again.
Blocks 20487777 and 20492483 still return all their extrinsics with the workaround removed, which is the thing this needed to prove.