Repository navigation
Refactor temperature message handling and enhance diagnostics - #194
Merged
Merged
Conversation
- Updated temperature message classes to correctly handle unsigned values and null states. - Adjusted FloatMessage to round values during encoding to prevent truncation errors. - Added regression tests for temperature decoding around 0°C to ensure accurate readings. - Implemented new tests for CRC failure logging and handling, including rate-limiting warnings and packet capture. - Enhanced framing recovery tests to handle oversized declared lengths and fragmented delivery. - Introduced tests for confirmed write transactions to ensure proper handling of ACK/NACK responses and write retries.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
…mments feat: implement freshness check for device attribute verification fix: enhance packet length validation comments in NASA client test: add tests for attribute verification and freshness checks
… emitted correctly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor temperature message handling to correctly process unsigned values and null states. Improve CRC diagnostics with new logging and handling features. Add regression tests to ensure accurate temperature readings around 0°C and confirm proper handling of ACK/NACK responses in write transactions.