Skip to content

Refactor temperature message handling and enhance diagnostics - #194

Merged
pantherale0 merged 4 commits into
mainfrom
research/temp-messages
Nov 15, 2026
Merged

pantherale0 merged 4 commits into
mainfrom
research/temp-messages

Conversation

@pantherale0

Copy link
Copy Markdown
Owner

Refactor temperature message handling to correctly process unsigned values and null states. Improve CRC diagnostics with new logging and handling features. Add regression tests to ensure accurate temperature readings around 0°C and confirm proper handling of ACK/NACK responses in write transactions.

- Updated temperature message classes to correctly handle unsigned values and null states.
- Adjusted FloatMessage to round values during encoding to prevent truncation errors.
- Added regression tests for temperature decoding around 0°C to ensure accurate readings.
- Implemented new tests for CRC failure logging and handling, including rate-limiting warnings and packet capture.
- Enhanced framing recovery tests to handle oversized declared lengths and fragmented delivery.
- Introduced tests for confirmed write transactions to ensure proper handling of ACK/NACK responses and write retries.
@codecov

codecov Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.83333% with 5 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
pysamsungnasa/nasa_client.py 93.15% 2 Missing and 3 partials ⚠️

📢 Thoughts on this report? Let us know!

…mments

feat: implement freshness check for device attribute verification
fix: enhance packet length validation comments in NASA client
test: add tests for attribute verification and freshness checks
@pantherale0
pantherale0 merged commit 8d49711 into main Nov 15, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant