Repository navigation
Conversation
discover_devices() only fetches the device list, so a caller can run Device.update() per device and handle a failing device itself. update() works as before.
11 of 21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to home-assistant/core#192892.
update()refreshes every device and logs and swallows any error from a single one, so a caller can't tell which console failed. This addsdiscover_devices(), which only fetches the device list (adding new devices todevices), so the caller can runDevice.update()per device and handle its errors.update()andcreate()work as before;update()now callsdiscover_devices()itself. Tests and a README note are included.