Repository navigation
Conversation
Device.update() fetched the monthly summary on every call, which costs two extra requests per console per poll for data that changes at most once a month. update() on Device and NintendoParental now take a keyword-only monthly_summary (default True, so existing callers see no change). NintendoParental.update() still fetches it for a device that has no monthly summary yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Device.update()fetches the monthly summary on every call. That's two extra requests per console per poll, for data that changes once a month.update()onDeviceandNintendoParentaltakes a keyword-onlymonthly_summaryargument. It defaults toTrue, so existing callers see no change; withFalsethe last summary is kept.NintendoParental.update(monthly_summary=False)still fetches it for a device that doesn't have one yet.This would let the Home Assistant integration fetch the monthly summary hourly instead of on every poll.
Suggested label:
enhancementPut together with AI assistance; tested with the suite, and on my own install with the default (
monthly_summary=True).