Skip to content

fix: Fixed resolutions reaching BLOCKED_DEADLOCK when a Step's state is modified externally #631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DrRebus wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −0
Open

fix: Fixed resolutions reaching BLOCKED_DEADLOCK when a Step's state is modified externally #631

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions engine/engine.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,6 +359,15 @@ func initialize(dbp zesty.DBProvider, publicID string, debugLogger *logrus.Entry
return nil, nil, nil
}

{
// Making sure to prune steps whose dependencies were updated outside the engine (API, manually in DB, etc)

@DrRebus DrRebus Apr 29, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also perform proactive pruning in the API's handlers whenever a resolution or step is updated, but doing it here also covers updates made in the database directly.

stepsToCheck := map[string]bool{}
for stepName := range res.Steps {
stepsToCheck[stepName] = true
}
Comment on lines +364 to +367
pruneSteps(res, stepsToCheck)
}
Comment on lines +362 to +369
Comment on lines +362 to +369

if err := dbp.Commit(); err != nil {
dbp.Rollback()
return nil, nil, err
Expand Down