Repository navigation
Pf2.profile: Add 'out' and 'format' option to control output - #86
Merged
Merged
Conversation
This patch adds convienience options for direct output from Pf2.profile. 'out' controls where to write the profile data, and 'format' controls the output format. Pf2.profile(out: <path>, format: :firefox) is expected to be a convienient way to replace manual saving + 'pf2 report' steps. Pf2.start/stop users still need to operate on raw profile data. This patch also changes Pf2::Reporter::FirefoxProfilerSer2 to emit a JSON string instead of a Hash, as its responsibility is to produce a representation that Firefox Profiler can directly comsume.
osyoyu
force-pushed
the
pf2-profile-options-out-format
branch
2 times, most recently
from
January 24, 2026 14:09
f9b67a2 to
dc5704e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds convienience options for direct output from Pf2.profile. 'out' controls where to write the profile data, and 'format' controls the output format.
Pf2.profile(out: <path>, format: :firefox)is expected to be a convienient way to replace manual saving + 'pf2 report' steps.Pf2.start/stop users still need to operate on raw profile data.
This patch also changes Pf2::Reporter::FirefoxProfilerSer2 to emit a JSON string instead of a Hash, as its responsibility is to produce a representation that Firefox Profiler can directly comsume.