fix: add missing --acc_precise arg and fix eval_one_file.sh bugs - #5
Open
jay-tau wants to merge 7 commits into
Open
fix: add missing --acc_precise arg and fix eval_one_file.sh bugs#5jay-tau wants to merge 7 commits into
jay-tau wants to merge 7 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jay-tau
force-pushed
the
fix/eval-script-and-docs
branch
from
March 8, 2026 06:35
07cf83f to
d4a561c
Compare
jay-tau
marked this pull request as ready for review
March 8, 2026 06:47
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
DeepReinforce
force-pushed
the
main
branch
4 times, most recently
from
March 30, 2026 06:44
8ed993d to
dbe0177
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6
OOTB, the command does not run. Hence, the fix
Changes
eval_one_file.sh$2→$1)rmto use-fflag and proper quotingshiftafter arg parsingREADME.md--acc_preciseto both example commands (offline and server)--acc_preciseto the arguments reference table--gpu_device_idfrom 7 to 0 in examples