Skip to content

nvpair: Improve native handling of unterminated strings - #18876

Open
ryao wants to merge 1 commit into
openzfs:masterfrom
ryao:nvpair_native_string_array-fix
Open

nvpair: Improve native handling of unterminated strings#18876
ryao wants to merge 1 commit into
openzfs:masterfrom
ryao:nvpair_native_string_array-fix

Conversation

@ryao

@ryao ryao commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Motivation and Context

This continues the work done in 59dc886 and parallels what is already done for XDR encoding.

Description

We change the algorithm to handle unterminated strings.

Grok 4.5 Build Beta found this bug.

How Has This Been Tested?

The buildbot can test it.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Quality assurance (non-breaking change which makes the code more robust against bugs)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist

This continues the work done in 59dc886
and parallels what is already done for XDR encoding.

Reported-by: Grok 4.5 Build Beta
Signed-off-by: Richard Yao <richard@ryao.dev>
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Aug 4, 2026
@behlendorf
behlendorf requested a review from tonyhutter August 5, 2026 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Code Review Needed Ready for review and testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants