snapcast: add libsoxr dependency to snapclient (as was done already for snapserver)#30079
Conversation
SNAPCAST_SOXR passes -DBUILD_WITH_SOXR, which is a build-wide CMake option: snapserver and snapclient are built from one source tree and both link libsoxr. The dependency was declared only on snapserver, so with SNAPCAST_SOXR enabled (the default) the snapclient package failed at the packaging step: Package snapclient is missing dependencies for the following libraries: libsoxr.so.0 Declare +SNAPCAST_SOXR:libsoxr on snapclient too, and relabel the option "(server + client)" so its build-wide scope is clear. Fixes: 7673cd9 ("snapcast: make build options explicit and per-package deps precise") Signed-off-by: Mirko Vogt <mirko-openwrt@nanl.de>
Formality Check: Suggestions AvailableWe completed the verification flow. Please review the formatting overview logs below.
|
Please wait for successful package build! |
Not sure I understand. This PR is fixing an issue - this very specific one actually - I introduced with the previous commit. I don't see the need for bumping PKG_RELEASE here, but if it makes everyone happy, I can do that, too, of course (it doesn't change anything for snapserver, and snapclient couldn't build with SOXR enabled, so for builds which succeeded, nothing changes). |
Yup! And I don't see / understand how that could happened with compile testing. 😕 I'm hoping this because the last PR weren't compile tested by GH Actions: it was merget before it. But sure, this is already a fixing commit, so if you are in a hurry, then land it! 👌 |
I'm not in a hurry, just figured landing it ASAP would save users potential trouble as well as automatic build resources. |
ACK!
Thanks. Let's wait for those workers on the next feature PR but not for "hotfixing" PRs! |
snapcast: add libsoxr dependency to snapclient
SNAPCAST_SOXR passes -DBUILD_WITH_SOXR, which is a build-wide CMake
option: snapserver and snapclient are built from one source tree and
both link libsoxr. The dependency was declared only on snapserver, so
with SNAPCAST_SOXR enabled (the default) the snapclient package failed
at the packaging step:
Package snapclient is missing dependencies for the following libraries:
libsoxr.so.0
Declare +SNAPCAST_SOXR:libsoxr on snapclient too, and relabel the option
"(server + client)" so its build-wide scope is clear.
📦 Package Details
Maintainer: @xabolcs @davidandreoletti
Szabolcs Hubai szab.hu@gmail.com, David Andreoletti david@andreoletti.net
Description:
see above
🧪 Run Testing Details
305c7599e5fa400cf6221fd0a596dbd014529235)✅ Formalities
If your PR contains a patch:
git am(e.g., subject line, commit description, etc.)
We must try to upstream patches to reduce maintenance burden.