wifi: mt7603: fix U-APSD EOSP signaling before frame transmission#1084
Open
bot08 wants to merge 2 commits into
Open
wifi: mt7603: fix U-APSD EOSP signaling before frame transmission#1084bot08 wants to merge 2 commits into
bot08 wants to merge 2 commits into
Conversation
Signed-off-by: bot08 <71845954+bot08@users.noreply.github.com>
|
mark |
Author
|
I tested this patch and didn't notice any difference. Packets are still being lost and ping gets "stuck" on devices that aggressively save battery. |
Author
|
Could it be because more_data is always 1? Or perhaps the issue wasn't fully resolved in #865, as the symptoms are very similar |
|
Hi @bot08, It should call ieee80211_sta_eosp after last sp frame is actually acknowledged |
Author
|
Hi @andburt-tlt, tested your patch today. Yeah, iPhone freezes are gone. But tx retries and packet loss are still high, looks like a separate bug. Overall, much better already. Also had a Wi-Fi restart due to WAN link drop, but that's unrelated. Here are the logs: System logKernel logStation dump@andburt-tlt should I add your patch as a commit to this PR, or would you prefer a separate one? Also noticed a new issue after applying the patch. |
Author
|
Unfortunately, the issue is still there, caught 2 freezes today. Also worth noting, I have another router with ath9k connected in cascade to the MT7628 one, both sharing the same config, and I don't observe any issues on it. So this is likely not a configuration problem |
|
@bot08, can you check the updated patch, it also acts on mt7603_sta_ps path: |
Author
|
@andburt-tlt Got worse with this patch :( Freezes and packet loss are still there. Maybe it should be applied together with the previous patch? I only applied this one. Here are 2 videos of how the freeze looks: |
|
@bot08 ok, maybe you can check the output of |
Author
|
@andburt-tlt I checked. Interestingly, when only the iPhone was connected, Here's the station dump captured during a freeze. An interesting fact, the iPhone was completely idle/sleeping during this time. It just lay on the table, but it never generated such a huge inactive time, it kept waking up or responding normally, maintaining a normal inactivity counter. |
Author
|
I think I stumbled upon an important clue while experimenting with the Coverage Cell Density setting on the router. The behavior changes completely depending on this option. When it is set to Normal, the iPhone doesn’t actually freeze anymore. Instead, it just quietly disconnects from the Wi-Fi on the phone's side. However, the router doesn't notice this immediately - it keeps showing the device as active and associated for a few minutes while the inactive time climbs all the way up. Eventually, hostapd just kicks it out due to inactivity. Here is what the logs look like under On the other hand, when I set Coverage Cell Density to Disabled, the iPhone doesn't drop the connection at all. It just experiences that total traffic freeze for some time (exactly as described in the issue above) but stays connected. |
Author
|
I also tested a new patch. The good news is that it successfully brought the TX retries down to much more realistic values, around +-5%. Unfortunately, it doesn't fix the underlying freeze or the disconnection issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1080