Conversation
Set MPLBACKEND environment variable for test execution.
…o ow-githubactions
skhayrulin
left a comment
skhayrulin
left a comment
There was a problem hiding this comment.
@pgleeson I’ve looked at the code, and the main comments concern style, though I’m not sure how critical that is.
| - name: Run tests | ||
| run: | | ||
|
|
||
| export NEURON_HOME=/home/runner/.local |
There was a problem hiding this comment.
Is it ok that we use full path to runner, I mean that could we be sure that folder /home/runner/.local is exist?
| import sys | ||
| import os | ||
|
|
||
| from test_utils import restructure_output_for_omv |
There was a problem hiding this comment.
I'm not sure that I understand for what this file for, but don't you think to use pytest for test run, and collecting information about which tests was ok and which is failed?
| if num_plotted_frames % 3 == 1: | ||
| time = ( | ||
| "%sms" % t_ms | ||
| if not t_ms == int(t_ms) |
There was a problem hiding this comment.
I think here is better compare with != operator?
| index+=1 | ||
|
|
||
| print_("Loaded: %s points from %s, showing %s points in %i plots"%(index,pos_file_name,points_plotted,num_plotted_frames)) | ||
| print_( |
There was a problem hiding this comment.
Use f string for python it's really more clear
f"Loaded: {index} points from {pos_file_name}, showing {points_plotted} points in {num_plotted_frames} plots"|
|
||
| count += 1 | ||
|
|
||
| import matplotlib.pyplot as plt |
There was a problem hiding this comment.
usually it's not good to add imports to function
2 participants
Adds Github action runs for most of the standard examples, checking that they produce expected output.
Fixes issues with configurations one_spring_test, test_energy, v_test_liquid
Adds SiberneticReplay.py, which can reload sibernetic simulations & visualise them for replay using pyvista. Try: