Skip to content

UCP/CORE: Increment completion count before calling uct_ep_flush #7332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmitrygx merged 1 commit into from
Sep 3, 2021
Merged

UCP/CORE: Increment completion count before calling uct_ep_flush #7332

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions src/ucp/core/ucp_worker.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2286,16 +2286,17 @@ ucp_worker_discard_uct_ep_pending_cb(uct_pending_req_t *self)
uct_ep_h uct_ep = req->send.discard_uct_ep.uct_ep;
ucs_status_t status;

++req->send.state.uct_comp.count;
status = uct_ep_flush(uct_ep, req->send.discard_uct_ep.ep_flush_flags,
&req->send.state.uct_comp);
if (status == UCS_OK) {
ucs_assert(req->send.state.uct_comp.count == 0);
ucp_worker_discard_uct_ep_flush_comp(&req->send.state.uct_comp);
return UCS_OK;
} else if (status == UCS_INPROGRESS) {
req->send.state.uct_comp.count++;
if (status == UCS_INPROGRESS) {
return UCS_OK;
} else if (status == UCS_ERR_NO_RESOURCE) {
}

--req->send.state.uct_comp.count;
ucs_assert(req->send.state.uct_comp.count == 0);

@yosefe yosefe Sep 2, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why assert == 0, are we use it started with 0? maybe assert >= 0?

@dmitrygx dmitrygx Sep 2, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it should be either 0 or 1


if (status == UCS_ERR_NO_RESOURCE) {
return UCS_ERR_NO_RESOURCE;
}

Expand Down