UCP/CORE: Implement flush+destroy for UCT EPs on UCP Worker #5608
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2454,7 +2454,10 @@ ucp_worker_discard_uct_ep_pending_cb(uct_pending_req_t *self) | |
| /* need to remove from the pending queue */ | ||
| status = UCS_OK; | ||
| } else { | ||
| /* make sure that uct_ep_flush() doenst return UCS_ERR_BUSY to not | ||
|
|
||
| * prevent the endless loop in this case */ | ||
| ucs_assert(status != UCS_ERR_BUSY); | ||
|
Contributor
There was a problem hiding this comment. this assert looks wrong since status value is returned by
Member
Author
There was a problem hiding this comment. this is not wrong, just to make sure that we will not enter the endless loop if
Contributor
There was a problem hiding this comment. but uct_ep_flush doc does not say that it cannot return
Member
Author
There was a problem hiding this comment.
yes, will handle it @yosefe what do you think to use progress_register() instead of this loop? |
||
| /* UCS_OK is handled here as well */ | ||
| ucp_worker_discard_uct_ep_flush_comp(&req->send.state.uct_comp, | ||
| status); | ||
| } | ||
|
yosefe marked this conversation as resolved.
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UCS_OK is not handled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is handled in the
elsesection