Skip to content

feat(aro-hcp): define slow jobs - #82502

Open
mbukatov wants to merge 1 commit into
openshift:mainfrom
mbukatov:mbukatov-slow-jobs
Open

feat(aro-hcp): define slow jobs#82502
mbukatov wants to merge 1 commit into
openshift:mainfrom
mbukatov:mbukatov-slow-jobs

Conversation

@mbukatov

@mbukatov mbukatov commented Jul 27, 2026

Copy link
Copy Markdown

Creating a slow prow periodics for a slow test suite, to get some data about actual runtime of the slow tests (which are not executed in highler environments right now). There are only 2 slow E2E tests so far:

$ ./aro-hcp-tests list tests --suite "stage/parallel/slow" | jq '.[].name'
"Customer should be able to rotate KMS key for a cluster with version >= 4.22"
"Customer should be able to update nodepool replicas and autoscaling"

Summary by CodeRabbit

Adds scheduled staging and production Prow periodic jobs for the ARO HCP slow E2E suite, enabling runtime data collection for KMS key rotation and nodepool replica/autoscaling tests.

Creating a slow prow periodics for a slow test suite, to get some data
about actual runtime of the slow tests (which are not executed in highler
environments right now). There are only 2 slow E2E tests so far:

```
$ ./aro-hcp-tests list tests --suite "stage/parallel/slow" | jq '.[].name'
"Customer should be able to rotate KMS key for a cluster with version >= 4.22"
"Customer should be able to update nodepool replicas and autoscaling"
```
@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 098c837b-5c54-4430-a28f-b21a374ddcbf

📥 Commits

Reviewing files that changed from the base of the PR and between bf71d3d and 126b1e6.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/Azure/ARO-HCP/Azure-ARO-HCP-main-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/Azure/ARO-HCP/Azure-ARO-HCP-main__periodic.yaml

Walkthrough

Adds scheduled staging and production ARO HCP parallel-slow E2E jobs to the periodic CI configuration, using the shared persistent workflow and environment-specific settings.

Changes

ARO HCP periodic E2E coverage

Layer / File(s) Summary
Scheduled parallel-slow E2E jobs
ci-operator/config/Azure/ARO-HCP/Azure-ARO-HCP-main__periodic.yaml
Adds staging and production jobs with distinct cron schedules, failure reporting, suite names, locations, vault profiles, and production subscription restrictions.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: roivaz

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: adding slow ARO-HCP jobs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR only adds periodic YAML entries; no Ginkgo test titles or test code changed, so there are no dynamic names to flag.
Test Structure And Quality ✅ Passed PR only adds periodic YAML/job config; no Ginkgo test code changed, so the test-quality checklist is not applicable.
Microshift Test Compatibility ✅ Passed Only CI periodic/job YAML changed; no Ginkgo test code or new e2e specs were added, so MicroShift compatibility isn't implicated.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only periodic job config changed; no Ginkgo test definitions or SNO-sensitive test logic were added.
Topology-Aware Scheduling Compatibility ✅ Passed The PR only adds CI periodic job definitions using an existing workflow; it doesn’t modify deployment manifests, operators, or controller scheduling logic.
Ote Binary Stdout Contract ✅ Passed PASS: PR only adds periodic YAML jobs; no process-level code, logging, or suite setup changed, so no stdout contract risk.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS: This PR only adds periodic job config; no Ginkgo e2e tests or network code changed, so the IPv6/disconnected compatibility check is not applicable.
No-Weak-Crypto ✅ Passed Only a Prow YAML config was changed; no MD5/SHA1/DES/RC4/3DES/Blowfish, custom crypto, or secret comparisons are present.
Container-Privileges ✅ Passed No added manifest fields set privileged/hostPID/hostNetwork/etc.; the PR only adds periodic job entries and standard ci-operator pod specs.
No-Sensitive-Data-In-Logs ✅ Passed Changed YAML only adds periodic job configs; no passwords, tokens, PII, or sensitive host/customer data appear in envs or log templates.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from raelga and stevekuznetsov July 27, 2026 16:58
@openshift-ci

openshift-ci Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mbukatov
Once this PR has been reviewed and has the lgtm label, please assign geoberle for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@mbukatov: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-Azure-ARO-HCP-main-periodic-stage-e2e-parallel-slow N/A periodic Periodic changed
periodic-ci-Azure-ARO-HCP-main-periodic-prod-e2e-parallel-slow N/A periodic Periodic changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

@mbukatov: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant