Skip to content

CMP-4475: Add e2e CI job for OCP-Virt cis-vm-extension profile#81659

Draft
taimurhafeez wants to merge 2 commits into
openshift:mainfrom
taimurhafeez:add-jobs-for-compliance-ocp-virt
Draft

CMP-4475: Add e2e CI job for OCP-Virt cis-vm-extension profile#81659
taimurhafeez wants to merge 2 commits into
openshift:mainfrom
taimurhafeez:add-jobs-for-compliance-ocp-virt

Conversation

@taimurhafeez

@taimurhafeez taimurhafeez commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds a new Prow CI job e2e-aws-ocp4-cis-vm-extension for the ComplianceAsCode/ocp4e2e repo
  • Tests the CIS VM Extension compliance profile against an AWS cluster with OpenShift Virtualization (CNV) installed
  • Uses the new -install-virt and -cel-content-file flags from ocp4e2e PR #78

Dependencies

  • Requires ComplianceAsCode/ocp4e2e#78 to be merged first (adds CNV install + CEL content flags)
  • CEL ProfileBundle wiring (vendored compliance-operator API bump to >= v1.9.0) is still in progress — job will not pass until that lands

Test plan

  • Verify job appears in PR checks for ComplianceAsCode/ocp4e2e after merge
  • Manually trigger with /test e2e-aws-ocp4-cis-vm-extension once CEL ProfileBundle support is complete
  • Confirm existing jobs are unaffected

🤖 Generated with Claude Code

Summary by CodeRabbit

Adds a new OpenShift CI Prow job for ComplianceAsCode/ocp4e2e that runs the CIS VM Extension compliance profile on AWS with OpenShift Virtualization enabled. The job is configured to use the ipi-aws workflow, set the required environment for make e2e-profile, and point at the new CEL content file needed for this profile.

This expands CI coverage for compliance testing in virtualized AWS clusters, but it still depends on the upstream ocp4e2e support for the new flags and the pending compliance-operator/CEL ProfileBundle wiring before it can pass reliably.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 9, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@taimurhafeez: This pull request references CMP-4475 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

  • Adds a new Prow CI job e2e-aws-ocp4-cis-vm-extension for the ComplianceAsCode/ocp4e2e repo
  • Tests the CIS VM Extension compliance profile against an AWS cluster with OpenShift Virtualization (CNV) installed
  • Uses the new -install-virt and -cel-content-file flags from ocp4e2e PR #78

Dependencies

  • Requires ComplianceAsCode/ocp4e2e#78 to be merged first (adds CNV install + CEL content flags)
  • CEL ProfileBundle wiring (vendored compliance-operator API bump to >= v1.9.0) is still in progress — job will not pass until that lands

Test plan

  • Verify job appears in PR checks for ComplianceAsCode/ocp4e2e after merge
  • Manually trigger with /test e2e-aws-ocp4-cis-vm-extension once CEL ProfileBundle support is complete
  • Confirm existing jobs are unaffected

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 9, 2026
@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/ComplianceAsCode/ocp4e2e/ComplianceAsCode-ocp4e2e-main-presubmits.yaml is excluded by !ci-operator/jobs/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 17823552-63c6-4f1a-a97b-3bd9b6bff809

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

Adds a new end-to-end test entry, e2e-aws-ocp4-cis-vm-extension, to the ComplianceAsCode ocp4e2e YAML configuration, specifying cluster profile, environment variables, exported command, CPU resource request, and workflow selection.

Changes

E2E Test Configuration Addition

Layer / File(s) Summary
New test entry definition
ci-operator/config/ComplianceAsCode/ocp4e2e/ComplianceAsCode-ocp4e2e-main.yaml
Adds e2e-aws-ocp4-cis-vm-extension test with quay-aws cluster profile, environment variables (BASE_DOMAIN, PROFILE, PRODUCT, INSTALL_VIRT, CEL_CONTENT_FILE), make e2e-profile command, 100m CPU request, and ipi-aws workflow.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: adding an e2e CI job for the OCP-Virt cis-vm-extension profile.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR only adds a ci-operator job in YAML; no Ginkgo test titles or dynamic test names were introduced.
Test Structure And Quality ✅ Passed PR only changes a ci-operator YAML job config; no Ginkgo test code was added or modified, so the test-structure check is not applicable.
Microshift Test Compatibility ✅ Passed The PR only adds a ci-operator YAML job entry; no Ginkgo test code or MicroShift-relevant APIs/features were introduced.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No new Ginkgo test code was added; the PR only introduces a CI job wrapper, so SNO compatibility checks are not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Change is only a Prow CI job YAML; no deployment manifests, controllers, or topology-sensitive scheduling fields were added.
Ote Binary Stdout Contract ✅ Passed PR only changes a ci-operator YAML job config; no OTE binary or process-level stdout code is touched, so the stdout contract isn’t violated here.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only adds a ci-operator job YAML; no new Ginkgo tests or network code were introduced, so the IPv4/disconnected compatibility check is not applicable.
No-Weak-Crypto ✅ Passed The PR only adds a CI job YAML entry; it contains no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or custom crypto code.
Container-Privileges ✅ Passed The new job stanza only sets env/commands/resources and uses workflow ipi-aws; it adds no privileged, host*, SYS_ADMIN, root, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs ✅ Passed The PR only adds a CI job config; it sets env vars and runs make without introducing any new logging of secrets or PII.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 9, 2026
@openshift-ci

openshift-ci Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: taimurhafeez
Once this PR has been reviewed and has the lgtm label, please assign yuumasato for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 9, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@taimurhafeez: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-ComplianceAsCode-ocp4e2e-main-e2e-aws-ocp4-cis-vm-extension ComplianceAsCode/ocp4e2e presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

- as: test
cli: latest
commands: |
export SKIP_CONTAINER_PUSH=true

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SKIP_CONTAINER_PUSH is a no-op here — ocp4e2e removed support for it back in 2021 (f78461e, "Remove SKIP_CONTAINER_PUSH support"), and current main doesn't read it anywhere. It's copied from the other lanes, so it's harmless, but has no effect on this job. Not blocking — we could drop it from all the ocp4e2e lanes in a separate cleanup PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants