[release-4.21] OCPBUGS-94114: support Parents field on origin test suites#31353
Conversation
…t suites Backport of origin#31261 to release-4.21. Adds Parents field to TestSuite struct and mergeParentQualifiers() function so that openshift/conformance parent suite inherits qualifiers from its parallel and serial children. Without this fix, openshift/conformance on 4.21 only picks up ~740 tests. With this fix, it correctly aggregates ~4000+ tests from child suites. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@bshaw7: This pull request references Jira Issue OCPBUGS-94114, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/payload-job periodic-ci-openshift-release-main-nightly-4.21-opct-external-aws-ccm |
|
@bshaw7: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c9a6f1f0-7490-11f1-8a0a-2ee973cea65b-0 |
|
CI tests shows expected count of 20-openshift-conformance-validated |
|
/jira refresh |
|
@bshaw7: This pull request references Jira Issue OCPBUGS-94114, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
@stbenjam: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@stbenjam: This pull request references Jira Issue OCPBUGS-94114, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bshaw7, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@bshaw7: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
7b5baf8
into
openshift:release-4.21
|
@bshaw7: Jira Issue Verification Checks: Jira Issue OCPBUGS-94114 Jira Issue OCPBUGS-94114 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Fix included in release 4.21.0-0.nightly-2026-07-09-155132 |
Summary
Backport of origin#31261 (Parents field fix for openshift/conformance suite) to release-4.21.
Same change as the 4.22 backport PR #31270.
What it does
Parents []stringfield toTestSuitestructmergeParentQualifiers()function for transitive qualifier propagationopenshift/conformance/parallelandopenshift/conformance/serialchildren ofopenshift/conformanceWithout this fix,
openshift/conformanceon 4.21 only picks up ~740 tests.With this fix, it correctly aggregates ~4000+ tests from child suites.
Testing
/cc @stbenjam