NO-JIRA: fix data race in TestEnqueueNodePoolsForCloudConfig

[jparrill]

Summary

• DeepCopy shared test objects before passing them to the fake client builder
• Parallel subtests were sharing the same HostedControlPlane and NodePool pointers, and fake.NewClientBuilder().WithObjects() mutates ResourceVersion on the objects causing a data race
• Pre-existing flaky test found while running the test suite with -race

🤖 Generated with Claude Code

Summary by CodeRabbit

• Tests
  • Improved test isolation by using independent copies of Kubernetes objects during setup.
  • Prevented test data from being unintentionally modified across test cases.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@jparrill: This pull request explicitly references no jira issue.

Details

In response to this:

Summary

• DeepCopy shared test objects before passing them to the fake client builder
• Parallel subtests were sharing the same HostedControlPlane and NodePool pointers, and fake.NewClientBuilder().WithObjects() mutates ResourceVersion on the objects causing a data race
• Pre-existing flaky test found while running the test suite with -race

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jparrill]

/area testing

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 91a45fca-8671-4803-b6ae-791254f85ef0

📥 Commits

Reviewing files that changed from the base of the PR and between 144cca9 and ffb00d0.

📒 Files selected for processing (1)

• hypershift-operator/controllers/nodepool/nodepool_controller_test.go

---

📝 Walkthrough

Walkthrough

TestEnqueueNodePoolsForCloudConfig now deep-copies each Kubernetes object from tc.objects into a new client.Object slice before constructing the fake client. The test uses these copies instead of the original input objects.

Possibly related PRs

• openshift/hypershift#9095: Also updates TestEnqueueNodePoolsForCloudConfig to deep-copy objects before fake-client construction.

Suggested reviewers: bryan-cox, csrwng, sdminonne

🚥 Pre-merge checks | ✅ 11

✅ Passed checks (11 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: fixing a data race in TestEnqueueNodePoolsForCloudConfig.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PASS: All test titles in the changed file are static literals/table names; no dynamic values, timestamps, IDs, or title construction patterns were found.
Test Structure And Quality	✅ Passed	PASS: the patch only deep-copies shared fixtures before fake client setup; the test remains single-purpose, has no waits/timeouts, and follows existing table-driven patterns.
Topology-Aware Scheduling Compatibility	✅ Passed	Only a test changed to deep-copy fake-client inputs; no deployment/controller scheduling logic or topology-sensitive constraints were introduced.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	Not applicable: the PR only deep-copies objects in a unit test; no new Ginkgo e2e tests, IPv4-only assumptions, or external connectivity were added.
No-Weak-Crypto	✅ Passed	Only change deep-copies test objects before fake client creation; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparison code was added.
Container-Privileges	✅ Passed	Only change is a Go test file deep-copying fake client inputs; no container/K8s manifests or privilege settings were modified.
No-Sensitive-Data-In-Logs	✅ Passed	The only code change deep-copies test objects before fake client creation; no new logging or sensitive literals were added.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[jparrill]

/close in favor of #9095

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jparrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [jparrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.51%. Comparing base (144cca9) to head (ffb00d0).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #9106   +/-   ##
=======================================
  Coverage   44.51%   44.51%           
=======================================
  Files         774      774           
  Lines       96997    96997           
=======================================
  Hits        43179    43179           
  Misses      50830    50830           
  Partials     2988     2988           

Flag	Coverage Δ
cmd-support	38.39% <ø> (ø)
cpo-hostedcontrolplane	47.22% <ø> (ø)
cpo-other	45.25% <ø> (ø)
hypershift-operator	54.45% <ø> (ø)
other	32.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[openshift-ci]

@jparrill: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[bryan-cox]

/close

[openshift-ci]

@bryan-cox: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.