[release-4.16] OCPBUGS-99075: fix(backport): konnectivity agent auth

[clebs]

What this PR does / why we need it:

Backport of #9031 to release-4.16.

Special notes for your reviewer:

Testing Plan:
test-ocpbugs-99014.md

Checklist:

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: db290652-2fd8-4c4d-9679-1a7fa52d918d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[clebs]

/jira cherry-pick OCPBUGS-99666

[openshift-ci-robot]

@clebs: Jira Issue OCPBUGS-99666 has been cloned as Jira Issue OCPBUGS-99667. Will retitle bug to link to clone.
/retitle OCPBUGS-99667: fix(backport): konnectivity agent auth to 4.16

Details

In response to this:

/jira cherry-pick OCPBUGS-99666

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@clebs: This pull request references Jira Issue OCPBUGS-99667, which is invalid:

• expected dependent Jira Issue OCPBUGS-99666 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead
• expected dependent Jira Issue OCPBUGS-99666 to target a version in 4.17.0, 4.17.z, but it targets "4.18.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

What this PR does / why we need it:

Backport of #9031 to release-4.16.

Special notes for your reviewer:

Testing Plan:
test-ocpbugs-99014.md

Checklist:

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@clebs: This pull request references Jira Issue OCPBUGS-99075, which is invalid:

• expected dependent Jira Issue OCPBUGS-99079 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ASSIGNED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

What this PR does / why we need it:

Backport of #9031 to release-4.16.

Special notes for your reviewer:

Testing Plan:
test-ocpbugs-99014.md

Checklist:

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: clebs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@clebs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-kubevirt-aws-ovn-reduced	a5acb45	link	true	/test e2e-kubevirt-aws-ovn-reduced
ci/prow/e2e-aws	a5acb45	link	true	/test e2e-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[csrwng]

Verification: PASS (release-4.16)

Verified on a live HostedCluster (cewong-guest-416, OCP 4.16.67). All 8 scenarios passed.

Test script: https://gist.github.com/csrwng/94e9e6d68a61f346823c29d61f4bd9d6

=== Setup: locating kube-apiserver pod ===
  Using pod: kube-apiserver-66766d649-xkcww

=== Scenario 1: --cluster-ca-cert flag present in konnectivity-server args ===
  PASS: flag --cluster-ca-cert found in konnectivity-server args

=== Scenario 2: --cluster-ca-cert points to /etc/konnectivity/ca/ca.crt ===
  PASS: CA cert path is /etc/konnectivity/ca/ca.crt

=== Scenario 3: CA file exists in konnectivity-server container ===
  PASS: CA file exists and contains a valid certificate

=== Scenario 4: konnectivity-server container is ready ===
  PASS: konnectivity-server container is ready

=== Scenario 5: konnectivity-agent pods healthy on guest cluster ===
  PASS: all 2/2 konnectivity-agent pods are running and ready

=== Scenario 6: Konnectivity tunnel connectivity ===
  PASS: oc get nodes via guest kubeconfig succeeded (tunnel works)

=== Scenario 7: unauthenticated TLS connection rejected on agent port (8091) ===
  PASS: unauthenticated connection was rejected or failed handshake

=== Scenario 8: fake client certificate rejected on agent port (8091) ===
  PASS: fake certificate was rejected

===========================================
 Results: 8 passed, 0 failed, 0 skipped
===========================================

[csrwng]

/verified by @csrwng

[openshift-ci-robot]

@csrwng: This PR has been marked as verified by @csrwng.

Details

In response to this:

/verified by @csrwng

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[csrwng]

Verification: PASS — test-ocpbugs-99014.sh (release-4.16)

Verified on live HostedCluster cewong-guest-416 (OCP 4.16.67). All 11 checks passed.

Full test log

HCP_NAMESPACE: clusters-cewong-guest-416
KAS_POD:       kube-apiserver-66766d649-xkcww
KAS_POD_IP:    10.139.1.79

============================================================
  Scenario 1: Verify --cluster-ca-cert flag
============================================================
  [PASS] --cluster-ca-cert flag present
  [PASS] --cluster-ca-cert points to /etc/konnectivity/ca/ca.crt

============================================================
  Scenario 2: Verify CA bundle mounted
============================================================
  [PASS] konnectivity-ca volume mount exists
  [PASS] konnectivity-ca-bundle ConfigMap exists
  [PASS] CA cert file is valid PEM

============================================================
  Scenario 3: Konnectivity agents connect (hosted cluster)
============================================================
  [PASS] konnectivity-agent pods running
  [PASS] No TLS errors in agent logs
  [PASS] No cert errors in server logs for legitimate agents

============================================================
  Scenario 4: Node communication through tunnel
============================================================
  [PASS] oc exec through tunnel works

============================================================
  Scenario 5: Reject connections without valid client certs
============================================================
  [PASS] Connection without client cert rejected
  [PASS] Connection with fake cert rejected

============================================================
  Summary
============================================================

  Total: 11  |  Passed: 11  |  Failed: 0  |  Skipped: 0

[openshift-ci-robot]

@clebs: Jira Issue Verification Checks: Jira Issue OCPBUGS-99075
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-99075 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

What this PR does / why we need it:

Backport of #9031 to release-4.16.

Special notes for your reviewer:

Testing Plan:
test-ocpbugs-99014.md

Checklist:

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.