CNTRLPLANE-3843: [release-4.22] feat: ho,cpo,hcco: expose console URL#9056
CNTRLPLANE-3843: [release-4.22] feat: ho,cpo,hcco: expose console URL#9056csrwng wants to merge 2 commits into
Conversation
Service operators would like to expose the console URL to users, and users control how the console URL actually gets routed by changing config in the cluster, so we need to read it from the cluster for the correct source of truth. Signed-off-by: Steve Kuznetsov <stekuznetsov@microsoft.com>
hcpstatus.Setup was removed from controllerFuncs because its constructor now needs capabilities, but allControllers() builds its list by iterating controllerFuncs. This meant the hcpstatus controller name was never in o.Controllers, making the special-case in the Run loop unreachable and the controller never started. Signed-off-by: Cesar Wong <cewong@redhat.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@csrwng: This pull request references CNTRLPLANE-3843 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target either version "4.22." or "openshift-4.22.", but it targets "5.0.0" instead. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csrwng The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@csrwng: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
Backport of #9008 to
release-4.22.ConfigOperatorReconciliationSucceededandValidHostedClusterStatusconditionsConflict resolution notes
reconcile_legacy.godoes not exist on release-4.22 (controller was not yet split); the equivalent changes (ConsoleURL propagation, ValidHostedClusterStatus condition) are applied directly inhostedcluster_controller.gotest/e2e/v2/tests/hosted_cluster_health_test.godoes not exist on release-4.22 (v2 test framework not present on this branch); dropped from backporttest/e2e/util/util.goadjusted fromVersion423/Version424toVersion422since the feature is being introduced in 4.22Version50,Version424,Version423not needed on this branch🤖 Generated with Claude Code