CNTRLPLANE-3690: Remove pre-4.12 DecompressAndDecodeConfig compatibility code and fix error message typo

[hypershift-jira-solve-ci]

What this PR does / why we need it:

OCP 4.12 is well past end-of-life, so all supported CPO versions have the DecompressAndDecodeConfig capability. This PR removes the dead compatibility code path and cleans up associated unused artifacts:

• Remove pre-4.12 fallback in token reconciliation: The conditional branch that fell back to uncompressed config for pre-4.12 CPOs is no longer needed.
• Remove unused types and constants: The DecompressAndDecodeConfig capability field, its image label constant, the orphaned Compressed() method, and the unused supportutil.Compress() function are all removed.
• Fix error message typo: Corrects "compress and decode" to "compress and encode" in reconcileTokenSecret to match the actual CompressedAndEncoded() method being called.
• Remove associated tests: Tests for the removed code paths are cleaned up.

Which issue(s) this PR fixes:

Fixes https://redhat.atlassian.net/browse/CNTRLPLANE-3690

Special notes for your reviewer:

The workflow file removal commit (c2f5a4fe) is a temporary artifact of the fork push process and will not appear in the final PR diff against upstream.

Checklist:

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

---

Always review AI generated responses prior to use.
Generated with Claude Code via openshift-developer plugin

---

Note: This PR was auto-generated by the jira-agent periodic CI job in response to CNTRLPLANE-3690. See the full report for token usage, cost breakdown, and detailed phase output.

Summary by CodeRabbit

• Changes

  • Node pool configuration data is now compressed and encoded for more reliable storage and processing.
  • Updated configuration token handling across node pool and machine provisioning workflows.
  • Removed the previous capability flag related to configuration decompression and decoding.

• Documentation

  • Removed automated documentation preview deployments for pull requests.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@hypershift-jira-solve-ci[bot]: This pull request references CNTRLPLANE-3690 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it:

OCP 4.12 is well past end-of-life, so all supported CPO versions have the DecompressAndDecodeConfig capability. This PR removes the dead compatibility code path and cleans up associated unused artifacts:

• Remove pre-4.12 fallback in token reconciliation: The conditional branch that fell back to uncompressed config for pre-4.12 CPOs is no longer needed.
• Remove unused types and constants: The DecompressAndDecodeConfig capability field, its image label constant, the orphaned Compressed() method, and the unused supportutil.Compress() function are all removed.
• Fix error message typo: Corrects "compress and decode" to "compress and encode" in reconcileTokenSecret to match the actual CompressedAndEncoded() method being called.
• Remove associated tests: Tests for the removed code paths are cleaned up.

Which issue(s) this PR fixes:

Fixes https://redhat.atlassian.net/browse/CNTRLPLANE-3690

Special notes for your reviewer:

The workflow file removal commit (c2f5a4fe) is a temporary artifact of the fork push process and will not appear in the final PR diff against upstream.

Checklist:

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

---

Always review AI generated responses prior to use.
Generated with Claude Code via openshift-developer plugin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

📝 Walkthrough

Walkthrough

The docs deployment preview workflow was removed. Nodepool configuration generation now returns gzip-compressed, base64-encoded data through CompressedAndEncoded, with updated tests. The nodepool controller no longer detects or exposes the decompression capability, and Karpenter token creation uses default capabilities. Token reconciliation error wording and affected tests were updated.

Suggested reviewers: enxebre, csrwng

🚥 Pre-merge checks | ✅ 11

✅ Passed checks (11 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	Inspected token_test.go and config_test.go; all test titles are static/descriptive, with no dynamic names, timestamps, UUIDs, node/pod/namespace values, or generated suffixes.
Test Structure And Quality	✅ Passed	Touched tests are plain table-driven unit tests; no Ginkgo hooks, cluster waits, or cleanup gaps were introduced, and the new round-trip test is single-purpose.
Topology-Aware Scheduling Compatibility	✅ Passed	PASS: The diff only renames token compression/error text and replaces a gzip helper; no affinity, nodeSelector, replica, or topology logic was added.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No new Ginkgo e2e tests were added; the changed tests are standard unit tests and don’t add external connectivity or IPv6-specific assumptions.
No-Weak-Crypto	✅ Passed	No weak crypto primitives, custom crypto, or secret/token comparisons were added; the PR only removes a compression fallback and updates wiring/error text.
Container-Privileges	✅ Passed	PR diff only changes Go files; no container/K8s manifests or privilege flags (privileged, hostPID/Network/IPC, SYS_ADMIN, allowPrivilegeEscalation) were added.
No-Sensitive-Data-In-Logs	✅ Passed	PASS: The PR only changes token/config error strings and capability wiring; no new log statements emit secrets, tokens, APIs, PII, or hostnames.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: removing DecompressAndDecodeConfig compatibility code and fixing the related error message.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hypershift-jira-solve-ci[bot]
Once this PR has been reviewed and has the lgtm label, please assign sjenning for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 44.29%. Comparing base (6142e46) to head (8661569).
⚠️ Report is 22 commits behind head on main.

Files with missing lines	Patch %	Lines
hypershift-operator/controllers/nodepool/token.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #9037   +/-   ##
=======================================
  Coverage   44.29%   44.29%           
=======================================
  Files         774      774           
  Lines       96828    96809   -19     
=======================================
- Hits        42891    42886    -5     
+ Misses      50976    50963   -13     
+ Partials     2961     2960    -1     

Files with missing lines	Coverage Δ
hypershift-operator/controllers/nodepool/config.go	83.19% <ø> (-0.14%)	⬇️
...erator/controllers/nodepool/nodepool_controller.go	43.28% <ø> (-0.07%)	⬇️
.../karpenterignition/karpenterignition_controller.go	64.80% <100.00%> (-0.15%)	⬇️
support/util/util.go	43.14% <ø> (+1.10%)	⬆️
hypershift-operator/controllers/nodepool/token.go	84.02% <0.00%> (+1.32%)	⬆️

Flag	Coverage Δ
cmd-support	38.33% <ø> (+0.01%)	⬆️
cpo-hostedcontrolplane	46.78% <ø> (ø)
cpo-other	45.22% <ø> (ø)
hypershift-operator	54.14% <0.00%> (+<0.01%)	⬆️
other	32.32% <100.00%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[openshift-ci]

@hypershift-jira-solve-ci[bot]: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[enxebre]

/hold

[openshift-ci]

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.