Skip to content

etcd-sharding: add omitzero to Replicas JSON tag #2059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jhjaggars wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

etcd-sharding: add omitzero to Replicas JSON tag #2059

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions enhancements/hypershift/etcd-sharding-by-resource-kind.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ type ManagedEtcdShardSpec struct {
// +kubebuilder:validation:Enum=1;3
// +kubebuilder:validation:Minimum=1
// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="replicas is immutable"
Replicas int32 `json:"replicas"`
Replicas int32 `json:"replicas,omitzero"`

// scheduling configures per-shard pod placement constraints. These
// constraints are merged with the framework's control plane node
Expand Down Expand Up @@ -651,7 +651,7 @@ top-level fields, which apply only to the default shard.
Storage ManagedEtcdShardStorageSpec `json:"storage,omitzero"`

// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="replicas is immutable"
Replicas int32 `json:"replicas"`
Replicas int32 `json:"replicas,omitzero"`

Scheduling EtcdShardSchedulingSpec `json:"scheduling,omitzero"`
}
Expand Down