CONSOLE-5209: Promote IngressComponentRouteLabels to Default

[jhadvig]

Summary

Promote the IngressComponentRouteLabels feature gate from TechPreview/DevPreview to Default (GA).

This is a WIP PR for running /test verify-feature-promotion to validate that all promotion requirements are met per the feature-zero-to-hero guide.

Change

- enable(inDevPreviewNoUpgrade(), inTechPreviewNoUpgrade()).
+ enable(inDevPreviewNoUpgrade(), inTechPreviewNoUpgrade(), inDefault()).

Promotion requirements

• At least 5 tests tagged [OCPFeatureGate:IngressComponentRouteLabels] — openshift/origin#31385
• Tests run at least 7 times per week across all platforms
• 95%+ pass rate
• Periodic jobs configured — openshift/release#81895
• 14 days before branch cut
• /test verify-feature-promotion passes

Dependencies

• API: openshift/api#2845 (merged) — Labels field on ComponentRouteSpec
• Operator: openshift/console-operator#1184 (in review) — label propagation
• Enhancement: openshift/enhancements#2033 (merged)

Jira

https://redhat.atlassian.net/browse/CONSOLE-5209

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@jhadvig: This pull request references CONSOLE-5209 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

Promote the IngressComponentRouteLabels feature gate from TechPreview/DevPreview to Default (GA).

This is a WIP PR for running /test verify-feature-promotion to validate that all promotion requirements are met per the feature-zero-to-hero guide.

Change

- enable(inDevPreviewNoUpgrade(), inTechPreviewNoUpgrade()).
+ enable(inDevPreviewNoUpgrade(), inTechPreviewNoUpgrade(), inDefault()).

Promotion requirements

• At least 5 tests tagged [OCPFeatureGate:IngressComponentRouteLabels] — openshift/origin#31385
• Tests run at least 7 times per week across all platforms
• 95%+ pass rate
• Periodic jobs configured — openshift/release#81895
• 14 days before branch cut
• /test verify-feature-promotion passes

Dependencies

• API: openshift/api#2845 (merged) — Labels field on ComponentRouteSpec
• Operator: openshift/console-operator#1184 (in review) — label propagation
• Enhancement: openshift/enhancements#2033 (merged)

Jira

https://redhat.atlassian.net/browse/CONSOLE-5209

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Hello @jhadvig! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

📝 Walkthrough

Walkthrough

FeatureGateIngressComponentRouteLabels is enabled for Default, OKD, DevPreviewNoUpgrade, and TechPreviewNoUpgrade configurations. Feature-gate manifests and documentation reflect the expanded enablement, and the Ingress CRD validates component route label maps, keys, reserved prefixes, and values.

Suggested reviewers: joelspeed, everettraven

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: promoting IngressComponentRouteLabels to Default.
Description check	✅ Passed	The description is directly related to the PR and explains the feature-gate promotion goal.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	No _test.go/spec files or Ginkgo titles were modified; the PR only updates feature gates, docs, and manifests.
Test Structure And Quality	✅ Passed	No Ginkgo test code was changed in this PR; only manifests, feature metadata, and generated CRDs were updated.
Microshift Test Compatibility	✅ Passed	PR changes only feature-gate/config manifests and CRD schema; no new Ginkgo e2e tests were added, so MicroShift compatibility is not implicated.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No Ginkgo e2e tests were added or changed; the PR only updates feature-gate metadata and manifests.
Topology-Aware Scheduling Compatibility	✅ Passed	Changed files only adjust feature-gate enablement/status and ingress label validation; no pod affinity, nodeSelector, replicas, or PDB logic was added.
Ote Binary Stdout Contract	✅ Passed	PR only changes feature-gate manifests and one registration line; no touched main/init/TestMain/BeforeSuite code or stdout writes were introduced.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	Only feature-gate/manifests changed; no new Ginkgo It/Describe/Context/When tests were added, so the IPv6/disconnected-network check is not applicable.
No-Weak-Crypto	✅ Passed	No MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret-comparison code was added; the diff only changes feature-gate/CRD YAML.
Container-Privileges	✅ Passed	No changed file adds or edits container specs/securityContext; diff only updates feature gates and CRD schema, with no privileged/host* or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs	✅ Passed	Changed files only update feature-gate enablement/docs and CRD schema; no logging/printf statements or secret/token/PII output was added.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign everettraven for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jhadvig]

/retest

[JoelSpeed]

/test verify-feature-promotion

[qodo-for-rh-openshift]

PR-Agent: could not find a component named verify-feature-promotion in a supported language in this PR.

[jhadvig]

/retest

[jhadvig]

/retest

[openshift-ci]

@jhadvig: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify-crd-schema	ff17708	link	true	/test verify-crd-schema
ci/prow/verify-feature-promotion	ff17708	link	true	/test verify-feature-promotion
ci/prow/verify-hypershift-integration	ff17708	link	true	/test verify-hypershift-integration

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.