[Backport 3.5] Fix handling of deletes during leading segment merge - #268
Merged
Conversation
* Revert "Revert of support deletes for incremental insertion (#240)" This reverts commit 4453ba9. Reverting the revert to be able to apply the fix. Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com> * Fix leading segment merge under deletions Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com> * Refine the "undo revert" commit These commits will all be squashed anyway, so this change helps reduce the splash zone of the final squashed commit without affecting functionality. Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com> * Add/fix changelog entries Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com> * Review comment updates Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com> * Add config to disable leading segment merge Also tweak some logs Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com> --------- Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com> (cherry picked from commit f33bb41)
opensearch-trigger-bot
Bot
requested review from
akash-shankaran,
jimdickinson,
sam-herman,
sandoichi and
tjake
as code owners
February 11, 2026 20:21
akash-shankaran
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport f33bb41 from #242