Revert of support deletes for incremental insertion#240
Merged
Conversation
Signed-off-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Andriy Redko <drreta@gmail.com>
akash-shankaran
approved these changes
Jan 28, 2026
akash-shankaran
left a comment
Collaborator
There was a problem hiding this comment.
awaiting testing before merging this change.
reta
marked this pull request as ready for review
January 29, 2026 19:19
reta
requested review from
jimdickinson,
sam-herman,
sandoichi and
tjake
as code owners
January 29, 2026 19:19
akash-shankaran
merged commit Feb 2, 2026
4453ba9
into
opensearch-project:main
38 of 44 checks passed
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-3.2 3.2
# Navigate to the new working tree
cd .worktrees/backport-3.2
# Create a new branch
git switch --create backport/backport-240-to-3.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4453ba91cee651425abd7680ca793400feee022c
# Push it to GitHub
git push --set-upstream origin backport/backport-240-to-3.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-3.2Then, create a pull request where the |
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-3.3 3.3
# Navigate to the new working tree
cd .worktrees/backport-3.3
# Create a new branch
git switch --create backport/backport-240-to-3.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4453ba91cee651425abd7680ca793400feee022c
# Push it to GitHub
git push --set-upstream origin backport/backport-240-to-3.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-3.3Then, create a pull request where the |
reta
added a commit
to reta/opensearch-jvector
that referenced
this pull request
Feb 2, 2026
…ct#240) * Revert of support deletes for incremental insertion Signed-off-by: Andriy Redko <drreta@gmail.com> * Revert defensive JVectorReader changes Signed-off-by: Andriy Redko <drreta@gmail.com> --------- Signed-off-by: Andriy Redko <drreta@gmail.com> (cherry picked from commit 4453ba9) Signed-off-by: Andriy Redko <drreta@gmail.com>
akash-shankaran
pushed a commit
that referenced
this pull request
Feb 2, 2026
akash-shankaran
pushed a commit
that referenced
this pull request
Feb 3, 2026
5 tasks
ashkrisk
added a commit
to ashkrisk/opensearch-jvector
that referenced
this pull request
Feb 5, 2026
…ch-project#240)" This reverts commit 4453ba9. Reverting the revert to be able to apply the fix. Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com>
akash-shankaran
pushed a commit
to akash-shankaran/opensearch-jvector
that referenced
this pull request
Feb 6, 2026
…ct#240) * Revert of support deletes for incremental insertion Signed-off-by: Andriy Redko <drreta@gmail.com> * Revert defensive JVectorReader changes Signed-off-by: Andriy Redko <drreta@gmail.com> --------- Signed-off-by: Andriy Redko <drreta@gmail.com> Signed-off-by: akash shankaran <akash.shankaran1@gmail.com>
akash-shankaran
pushed a commit
that referenced
this pull request
Feb 11, 2026
* Revert "Revert of support deletes for incremental insertion (#240)" This reverts commit 4453ba9. Reverting the revert to be able to apply the fix. Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com> * Fix leading segment merge under deletions Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com> * Refine the "undo revert" commit These commits will all be squashed anyway, so this change helps reduce the splash zone of the final squashed commit without affecting functionality. Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com> * Add/fix changelog entries Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com> * Review comment updates Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com> * Add config to disable leading segment merge Also tweak some logs Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com> --------- Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com>
opensearch-trigger-bot Bot
pushed a commit
that referenced
this pull request
Feb 11, 2026
* Revert "Revert of support deletes for incremental insertion (#240)" This reverts commit 4453ba9. Reverting the revert to be able to apply the fix. Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com> * Fix leading segment merge under deletions Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com> * Refine the "undo revert" commit These commits will all be squashed anyway, so this change helps reduce the splash zone of the final squashed commit without affecting functionality. Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com> * Add/fix changelog entries Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com> * Review comment updates Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com> * Add config to disable leading segment merge Also tweak some logs Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com> --------- Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com> (cherry picked from commit f33bb41)
opensearch-trigger-bot Bot
pushed a commit
that referenced
this pull request
Feb 11, 2026
* Revert "Revert of support deletes for incremental insertion (#240)" This reverts commit 4453ba9. Reverting the revert to be able to apply the fix. Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com> * Fix leading segment merge under deletions Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com> * Refine the "undo revert" commit These commits will all be squashed anyway, so this change helps reduce the splash zone of the final squashed commit without affecting functionality. Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com> * Add/fix changelog entries Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com> * Review comment updates Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com> * Add config to disable leading segment merge Also tweak some logs Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com> --------- Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com> (cherry picked from commit f33bb41)
akash-shankaran
pushed a commit
that referenced
this pull request
Feb 11, 2026
* Revert "Revert of support deletes for incremental insertion (#240)" This reverts commit 4453ba9. Reverting the revert to be able to apply the fix. * Fix leading segment merge under deletions * Refine the "undo revert" commit These commits will all be squashed anyway, so this change helps reduce the splash zone of the final squashed commit without affecting functionality. * Add/fix changelog entries * Review comment updates * Add config to disable leading segment merge Also tweak some logs --------- (cherry picked from commit f33bb41) Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com> Co-authored-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com>
reta
pushed a commit
to reta/opensearch-jvector
that referenced
this pull request
Feb 11, 2026
…ect#242) * Revert "Revert of support deletes for incremental insertion (opensearch-project#240)" This reverts commit 4453ba9. Reverting the revert to be able to apply the fix. Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com> * Fix leading segment merge under deletions Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com> * Refine the "undo revert" commit These commits will all be squashed anyway, so this change helps reduce the splash zone of the final squashed commit without affecting functionality. Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com> * Add/fix changelog entries Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com> * Review comment updates Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com> * Add config to disable leading segment merge Also tweak some logs Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com> --------- Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com> (cherry picked from commit f33bb41)
akash-shankaran
added a commit
that referenced
this pull request
Feb 11, 2026
* Revert "Revert of support deletes for incremental insertion (#240)" This reverts commit 4453ba9. Reverting the revert to be able to apply the fix. * Fix leading segment merge under deletions * Refine the "undo revert" commit These commits will all be squashed anyway, so this change helps reduce the splash zone of the final squashed commit without affecting functionality. * Add/fix changelog entries * Review comment updates * Add config to disable leading segment merge Also tweak some logs --------- (cherry picked from commit f33bb41) Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com> Co-authored-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com> Co-authored-by: Akash Shankaran <akash.shankaran1@gmail.com>
akash-shankaran
pushed a commit
that referenced
this pull request
Feb 11, 2026
* Revert "Revert of support deletes for incremental insertion (#240)" This reverts commit 4453ba9. Reverting the revert to be able to apply the fix. * Fix leading segment merge under deletions * Refine the "undo revert" commit These commits will all be squashed anyway, so this change helps reduce the splash zone of the final squashed commit without affecting functionality. * Add/fix changelog entries * Review comment updates * Add config to disable leading segment merge Also tweak some logs --------- (cherry picked from commit f33bb41) Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com> Co-authored-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Revert of support deletes for incremental insertion (#203)
Related Issues
Resolves numerous
assertions andIllegalArgumentExceptions :(Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.