Skip to content

Revert of support deletes for incremental insertion#240

Merged
akash-shankaran merged 2 commits into
opensearch-project:mainfrom
reta:revert.inplace
Feb 2, 2026
Merged

Revert of support deletes for incremental insertion#240
akash-shankaran merged 2 commits into
opensearch-project:mainfrom
reta:revert.inplace

Conversation

@reta

@reta reta commented Jan 28, 2026

Copy link
Copy Markdown
Collaborator

Description

Revert of support deletes for incremental insertion (#203)

Related Issues

Resolves numerous assertions and IllegalArgumentExceptions :(

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

reta added 2 commits January 28, 2026 16:19
Signed-off-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Andriy Redko <drreta@gmail.com>

@akash-shankaran akash-shankaran left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awaiting testing before merging this change.

@reta
reta marked this pull request as ready for review January 29, 2026 19:19
@akash-shankaran
akash-shankaran merged commit 4453ba9 into opensearch-project:main Feb 2, 2026
38 of 44 checks passed
@opensearch-trigger-bot

Copy link
Copy Markdown
Contributor

The backport to 3.2 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-3.2 3.2
# Navigate to the new working tree
cd .worktrees/backport-3.2
# Create a new branch
git switch --create backport/backport-240-to-3.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4453ba91cee651425abd7680ca793400feee022c
# Push it to GitHub
git push --set-upstream origin backport/backport-240-to-3.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-3.2

Then, create a pull request where the base branch is 3.2 and the compare/head branch is backport/backport-240-to-3.2.

reta added a commit to reta/opensearch-jvector that referenced this pull request Feb 2, 2026
…ct#240)

* Revert of support deletes for incremental insertion

Signed-off-by: Andriy Redko <drreta@gmail.com>

* Revert defensive JVectorReader changes

Signed-off-by: Andriy Redko <drreta@gmail.com>

---------

Signed-off-by: Andriy Redko <drreta@gmail.com>
(cherry picked from commit 4453ba9)
@opensearch-trigger-bot

Copy link
Copy Markdown
Contributor

The backport to 3.3 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-3.3 3.3
# Navigate to the new working tree
cd .worktrees/backport-3.3
# Create a new branch
git switch --create backport/backport-240-to-3.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4453ba91cee651425abd7680ca793400feee022c
# Push it to GitHub
git push --set-upstream origin backport/backport-240-to-3.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-3.3

Then, create a pull request where the base branch is 3.3 and the compare/head branch is backport/backport-240-to-3.3.

reta added a commit to reta/opensearch-jvector that referenced this pull request Feb 2, 2026
…ct#240)

* Revert of support deletes for incremental insertion

Signed-off-by: Andriy Redko <drreta@gmail.com>

* Revert defensive JVectorReader changes

Signed-off-by: Andriy Redko <drreta@gmail.com>

---------

Signed-off-by: Andriy Redko <drreta@gmail.com>
(cherry picked from commit 4453ba9)
reta added a commit to reta/opensearch-jvector that referenced this pull request Feb 2, 2026
…ct#240)

* Revert of support deletes for incremental insertion

Signed-off-by: Andriy Redko <drreta@gmail.com>

* Revert defensive JVectorReader changes

Signed-off-by: Andriy Redko <drreta@gmail.com>

---------

Signed-off-by: Andriy Redko <drreta@gmail.com>
(cherry picked from commit 4453ba9)
Signed-off-by: Andriy Redko <drreta@gmail.com>
akash-shankaran pushed a commit that referenced this pull request Feb 2, 2026
* Revert of support deletes for incremental insertion



* Revert defensive JVectorReader changes



---------


(cherry picked from commit 4453ba9)

Signed-off-by: Andriy Redko <drreta@gmail.com>
akash-shankaran pushed a commit that referenced this pull request Feb 3, 2026
* Revert of support deletes for incremental insertion



* Revert defensive JVectorReader changes



---------


(cherry picked from commit 4453ba9)

Signed-off-by: Andriy Redko <drreta@gmail.com>
ashkrisk added a commit to ashkrisk/opensearch-jvector that referenced this pull request Feb 5, 2026
…ch-project#240)"

This reverts commit 4453ba9.

Reverting the revert to be able to apply the fix.

Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com>
akash-shankaran pushed a commit to akash-shankaran/opensearch-jvector that referenced this pull request Feb 6, 2026
…ct#240)

* Revert of support deletes for incremental insertion

Signed-off-by: Andriy Redko <drreta@gmail.com>

* Revert defensive JVectorReader changes

Signed-off-by: Andriy Redko <drreta@gmail.com>

---------

Signed-off-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: akash shankaran <akash.shankaran1@gmail.com>
akash-shankaran pushed a commit that referenced this pull request Feb 11, 2026
* Revert "Revert of support deletes for incremental insertion (#240)"

This reverts commit 4453ba9.

Reverting the revert to be able to apply the fix.

Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com>

* Fix leading segment merge under deletions

Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com>

* Refine the "undo revert" commit

These commits will all be squashed anyway, so this change helps reduce
the splash zone of the final squashed commit without affecting
functionality.

Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com>

* Add/fix changelog entries

Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com>

* Review comment updates

Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com>

* Add config to disable leading segment merge

Also tweak some logs

Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com>

---------

Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com>
opensearch-trigger-bot Bot pushed a commit that referenced this pull request Feb 11, 2026
* Revert "Revert of support deletes for incremental insertion (#240)"

This reverts commit 4453ba9.

Reverting the revert to be able to apply the fix.

Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com>

* Fix leading segment merge under deletions

Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com>

* Refine the "undo revert" commit

These commits will all be squashed anyway, so this change helps reduce
the splash zone of the final squashed commit without affecting
functionality.

Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com>

* Add/fix changelog entries

Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com>

* Review comment updates

Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com>

* Add config to disable leading segment merge

Also tweak some logs

Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com>

---------

Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com>
(cherry picked from commit f33bb41)
opensearch-trigger-bot Bot pushed a commit that referenced this pull request Feb 11, 2026
* Revert "Revert of support deletes for incremental insertion (#240)"

This reverts commit 4453ba9.

Reverting the revert to be able to apply the fix.

Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com>

* Fix leading segment merge under deletions

Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com>

* Refine the "undo revert" commit

These commits will all be squashed anyway, so this change helps reduce
the splash zone of the final squashed commit without affecting
functionality.

Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com>

* Add/fix changelog entries

Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com>

* Review comment updates

Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com>

* Add config to disable leading segment merge

Also tweak some logs

Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com>

---------

Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com>
(cherry picked from commit f33bb41)
akash-shankaran pushed a commit that referenced this pull request Feb 11, 2026
* Revert "Revert of support deletes for incremental insertion (#240)"

This reverts commit 4453ba9.

Reverting the revert to be able to apply the fix.



* Fix leading segment merge under deletions



* Refine the "undo revert" commit

These commits will all be squashed anyway, so this change helps reduce
the splash zone of the final squashed commit without affecting
functionality.



* Add/fix changelog entries



* Review comment updates



* Add config to disable leading segment merge

Also tweak some logs



---------


(cherry picked from commit f33bb41)

Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com>
Co-authored-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com>
reta pushed a commit to reta/opensearch-jvector that referenced this pull request Feb 11, 2026
…ect#242)

* Revert "Revert of support deletes for incremental insertion (opensearch-project#240)"

This reverts commit 4453ba9.

Reverting the revert to be able to apply the fix.

Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com>

* Fix leading segment merge under deletions

Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com>

* Refine the "undo revert" commit

These commits will all be squashed anyway, so this change helps reduce
the splash zone of the final squashed commit without affecting
functionality.

Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com>

* Add/fix changelog entries

Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com>

* Review comment updates

Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com>

* Add config to disable leading segment merge

Also tweak some logs

Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com>

---------

Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com>
(cherry picked from commit f33bb41)
akash-shankaran added a commit that referenced this pull request Feb 11, 2026
* Revert "Revert of support deletes for incremental insertion (#240)"

This reverts commit 4453ba9.

Reverting the revert to be able to apply the fix.



* Fix leading segment merge under deletions



* Refine the "undo revert" commit

These commits will all be squashed anyway, so this change helps reduce
the splash zone of the final squashed commit without affecting
functionality.



* Add/fix changelog entries



* Review comment updates



* Add config to disable leading segment merge

Also tweak some logs



---------


(cherry picked from commit f33bb41)

Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com>
Co-authored-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com>
Co-authored-by: Akash Shankaran <akash.shankaran1@gmail.com>
akash-shankaran pushed a commit that referenced this pull request Feb 11, 2026
* Revert "Revert of support deletes for incremental insertion (#240)"

This reverts commit 4453ba9.

Reverting the revert to be able to apply the fix.



* Fix leading segment merge under deletions



* Refine the "undo revert" commit

These commits will all be squashed anyway, so this change helps reduce
the splash zone of the final squashed commit without affecting
functionality.



* Add/fix changelog entries



* Review comment updates



* Add config to disable leading segment merge

Also tweak some logs



---------


(cherry picked from commit f33bb41)

Signed-off-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com>
Co-authored-by: Ashwin Krishna Kumar <nebulousmagneticwind@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants