feat(execd): add preStart and periodic lifecycle hooks - #1587
Open
jianpingpei wants to merge 3 commits into
Open
feat(execd): add preStart and periodic lifecycle hooks#1587jianpingpei wants to merge 3 commits into
jianpingpei wants to merge 3 commits into
Conversation
jianpingpei
requested review from
Pangjiping,
hittyt,
jwx0925 and
ninan-nn
as code owners
August 20, 2026 05:11
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2775a5d373
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
jianpingpei
force-pushed
the
feature/osep-0020-prestart-periodic-hooks
branch
from
August 20, 2026 07:34
2775a5d to
9d8eb97
Compare
This was referenced Aug 20, 2026
Pangjiping
reviewed
Aug 21, 2026
Pangjiping
reviewed
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OPEN_SANDBOX_LIFECYCLEtransport.preStart, then start periodic hooks and release the user process only afterpreStartsucceeds.preStart, and only then launch the supervised user entrypoint.periodichooks through execd's init-reaper-aware managed process path.$HOME/.execd/lifecycle.toml;EXECD_LIFECYCLE_CONFIGremains an exact explicit override.Related to #1542.
Testing
Commands and verification:
go test -count=1 -race ./pkg/lifecycle ./pkg/runtime .go vet ./...go mod tidy -diffgolangci-lint v1.64.8 run ./...bash -n bootstrap.sh tests/lifecycle.shanddash -n bootstrap.shbash tests/lifecycle.shsh,dash, andbash: 500 immediate watchdog start/stop cycles each, with no residual sleep processsh,dash, andbash/pingwas available duringpreStart; periodic hooks and the user command started only afterpreStart; internal lifecycle env was absent from user work/pingwas available duringpreStart; the supervised entrypoint started only afterward; TERM duringpreStartskipped the entrypoint and exited cleanlyThe full
go test ./pkg/...suite still has the existing macOS/var -> /private/varpkg/isolationfailures; the same failures reproduce on the unchanged baseline. CI runs this suite on Linux.Breaking Changes
Checklist