Go: perform type validation in tests - #8573
Draft
greg-at-moderne wants to merge 1 commit into
Draft
Conversation
timtebeek
reviewed
Aug 21, 2026
| private Assertions() { | ||
| } | ||
|
|
||
| public static SourceFile validateTypes(SourceFile source, TypeValidation typeValidation) { |
Member
There was a problem hiding this comment.
As discussed; whilst already valuable, for now this is a misnomer: we only validate no unknowns/erroneous elements are added, whereas we likely want to validate no missing/nil types are present.
TypeValidation itself is misnamed as well, as it's been adding more and more types of validations we could opt into, like the addition that no non-whitespace characters should be present in any prefix, as another guard on the parser we could add here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
What's your motivation?
Anything in particular you'd like reviewers to focus on?
Anyone you would like to review specifically?
Have you considered any alternatives or workarounds?
Any additional context
Checklist
./gradlew buildlocally, and committed any resulting changes torecipes.csv