Skip to content

Go: perform type validation in tests - #8573

Draft
greg-at-moderne wants to merge 1 commit into
mainfrom
greg-go-honor-type-validation
Draft

Go: perform type validation in tests#8573
greg-at-moderne wants to merge 1 commit into
mainfrom
greg-go-honor-type-validation

Conversation

@greg-at-moderne

Copy link
Copy Markdown
Contributor

What's changed?

What's your motivation?

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

private Assertions() {
}

public static SourceFile validateTypes(SourceFile source, TypeValidation typeValidation) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed; whilst already valuable, for now this is a misnomer: we only validate no unknowns/erroneous elements are added, whereas we likely want to validate no missing/nil types are present.

TypeValidation itself is misnamed as well, as it's been adding more and more types of validations we could opt into, like the addition that no non-whitespace characters should be present in any prefix, as another guard on the parser we could add here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

2 participants