JavaScript: resolve transitive deps from npm v1 lock files - #8566
Open
bmuschko wants to merge 1 commit into
Open
JavaScript: resolve transitive deps from npm v1 lock files#8566bmuschko wants to merge 1 commit into
bmuschko wants to merge 1 commit into
Conversation
sambsnyd
approved these changes
Aug 19, 2026
sambsnyd
left a comment
sambsnyd
left a comment
Member
There was a problem hiding this comment.
I don't know NPM dependency resolution semantics deeply enough to comment on whether this is correct, but it looks reasonable to me
github-project-automation
Bot
moved this from In Progress
to Ready to Review
in OpenRewrite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
org.openrewrite.javascript.search.DependencyInsightdid not report transitive dependencies from a committedpackage-lock.jsonwhen "Include transitive dependencies" was selected.The npm lock file parser only understood the modern
packagesmap (lockfileVersion 2/3). A lockfileVersion 1 file (npm 5/6) has nopackagesmap, only a nesteddependenciestree, so the parser produced an empty resolved-dependency graph. Direct dependencies were still matched by name, but every transitive match was silently lost.The parser now converts a legacy v1
dependenciestree into the same internal shape, so transitive dependencies resolve from v1 lock files just as they do from v2/v3.