Skip to content

JavaTemplate: add failing tests for literal #{ in template source #8470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
martinfrancois wants to merge 1 commit into from
Closed

JavaTemplate: add failing tests for literal #{ in template source #8470

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 63 additions & 0 deletions rewrite-java-test/src/test/java/org/openrewrite/java/JavaTemplateSubstitutionsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
package org.openrewrite.java;

import org.junit.jupiter.api.Test;
import org.junitpioneer.jupiter.ExpectedToFail;
import org.openrewrite.DocumentExample;
import org.openrewrite.ExecutionContext;
import org.openrewrite.Issue;
Expand Down Expand Up @@ -336,6 +337,68 @@ public class Test {
);
}

@ExpectedToFail("JavaTemplate has no escape for a literal #{ in template source")
@Issue("https://github.com/openrewrite/rewrite-static-analysis/pull/976")
@Test
void hashBraceInStringLiteral() {
rewriteRun(
spec -> spec.recipe(toRecipe(() -> new JavaVisitor<>() {
@Override
public J visitLiteral(J.Literal literal, ExecutionContext ctx) {
if ("placeholder".equals(literal.getValue())) {
return JavaTemplate.builder("\"#{foo}\"")
.build()
.apply(getCursor(), literal.getCoordinates().replace());
}
return super.visitLiteral(literal, ctx);
}
})),
java(
"""
public class Test {
String s = "placeholder";
}
""",
"""
public class Test {
String s = "#{foo}";
}
"""
)
);
}

@ExpectedToFail("Substitutions loops replacePlaceholders to a fixed point, so the #{ unescaped in pass 1 is re-parsed as a placeholder in pass 2")
@Issue("https://github.com/openrewrite/rewrite-static-analysis/pull/976")
@Test
void escapedHashBraceInStringLiteral() {
rewriteRun(
spec -> spec.recipe(toRecipe(() -> new JavaVisitor<>() {
@Override
public J visitLiteral(J.Literal literal, ExecutionContext ctx) {
if ("placeholder".equals(literal.getValue())) {
return JavaTemplate.builder("\"\\#{foo}\"")
.build()
.apply(getCursor(), literal.getCoordinates().replace());
}
return super.visitLiteral(literal, ctx);
}
})),
java(
"""
public class Test {
String s = "placeholder";
}
""",
"""
public class Test {
String s = "#{foo}";
}
"""
)
);
}

@Issue("https://github.com/openrewrite/rewrite/issues/1985")
@Test
void newArray() {
Expand Down