Preserve CharSequence assertions in sequenced collections

[martinfrancois]

Suggested review order: 20 of 52 (Score: 6.5)
Review first: #1094

What's changed?

Leaves a sequenced-collection assertion unchanged when the selected element uses a CharSequence-specific AssertJ assertion. Assertions supported by the generic element assertion continue to use .first() or .last().

What's your motivation?

Recipe: org.openrewrite.java.testing.assertj.SimplifySequencedCollectionAssertions.

I found this by running org.openrewrite.java.testing.assertj.SimplifySequencedCollectionAssertions from org.openrewrite.recipe:rewrite-testing-frameworks:3.42.0 on TrelloClientTest.java in Symphony-Trello at a8013f27. I reproduced the same result with the latest released recipe artifact, org.openrewrite.recipe:rewrite-testing-frameworks:3.44.0. ./mvnw -DskipTests test-compile then fails because .first() returns ObjectAssert<String>, which has no startsWith(String) method.

Before

assertThat(readRequests.getFirst())
        .startsWith("GET /1/boards/board-1/cards/open?")
        .contains("fields=")
        .doesNotContain("actions=");

Actual after the recipe

assertThat(readRequests).first()
        .startsWith("GET /1/boards/board-1/cards/open?")
        .contains("fields=")
        .doesNotContain("actions=");

Expected after the recipe

(unchanged)

The rewrite changes the AssertJ assertion type from a string assertion to a generic object assertion. The fluent string methods are then unavailable, so the transformed target does not compile.

Confirmed real-world execution

• Project: Symphony-Trello.
• Location: TrelloClientTest.java at a8013f27.
• Discovery checkout: martinfrancois/symphony-trello@a8013f27.

Anything in particular you'd like reviewers to focus on?

Please review the assertion-chain scan and the distinction between generic equality assertions and CharSequence-specific operations.

Have you considered any alternatives or workarounds?

Adding another AssertJ narrowing operation would make the result more complex than the original. Leaving this chain unchanged is both shorter and type-safe.

Any additional context

Pre-existing tests changed: SimplifySequencedCollectionAssertionsTest.java.withDifferentAssertions (updated).

• Target commit: martinfrancois/symphony-trello@a8013f27
• Discovery release: org.openrewrite.recipe:rewrite-testing-frameworks:3.42.0
• Latest verification release: org.openrewrite.recipe:rewrite-testing-frameworks:3.44.0
• Upstream reproduction commit: openrewrite/rewrite-testing-frameworks@23a04efc
• Focused tests: SimplifySequencedCollectionAssertionsTest

This change was prepared with AI assistance. I reviewed the target execution evidence, implementation, tests, and contribution text.

Checklist

• I've added unit tests to cover both positive and negative cases
• I've read and applied the recipe conventions and best practices
• I've run ./gradlew build locally, and committed any resulting changes to recipes.csv
• I've formatted the lines I changed, without reformatting code I didn't touch