Skip to content

Place @Nullable correctly on qualified nested return types #996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
martinfrancois wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Place @Nullable correctly on qualified nested return types #996

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions src/test/java/org/openrewrite/staticanalysis/NullableOnMethodReturnTypeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
package org.openrewrite.staticanalysis;

import org.junit.jupiter.api.Test;
import org.junitpioneer.jupiter.ExpectedToFail;
import org.openrewrite.DocumentExample;
import org.openrewrite.test.RecipeSpec;
import org.openrewrite.test.RewriteTest;
Expand Down Expand Up @@ -96,6 +97,39 @@ public class Foo {
);
}

@ExpectedToFail("Annotation is placed before the qualified name, producing `@Nullable Map.Entry` which javac rejects")
@Test
void moveNullableToNestedTypeSimpleName() {
rewriteRun(
//language=java
java(
"""
import org.jspecify.annotations.Nullable;

import java.util.Map;

class Test<K, V> {
@Nullable
public Map.Entry<K, V> entry() {
return null;
}
}
""",
"""
import org.jspecify.annotations.Nullable;

import java.util.Map;

class Test<K, V> {
public Map.@Nullable Entry<K, V> entry() {
return null;
}
}
"""
)
);
}

@Test
void dontTouchArguments() {
rewriteRun(
Expand Down
Loading