Skip to content
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@
package org.openrewrite.staticanalysis;

import org.junit.jupiter.api.Test;
import org.junitpioneer.jupiter.ExpectedToFail;
import org.openrewrite.DocumentExample;
import org.openrewrite.Issue;
import org.openrewrite.test.RecipeSpec;
import org.openrewrite.test.RewriteTest;

Expand Down Expand Up @@ -60,6 +62,45 @@ protected void finalize() throws Throwable {
);
}

@ExpectedToFail("Widens neither throws clause, and the second cycle inserts a duplicate super.finalize() into the subclass; needs hierarchy-aware handling")
@Issue("https://github.com/openrewrite/rewrite-static-analysis/pull/969")
@Test
void addsSuperFinalizeAndWidensThrowsAcrossClassHierarchy() {
rewriteRun(
//language=java
java(
"""
class A {
@Override
protected void finalize() {
}
}

class B extends A {
@Override
protected void finalize() {
}
}
""",
"""
class A {
@Override
protected void finalize() throws Throwable {
super.finalize();
}
}

class B extends A {
@Override
protected void finalize() throws Throwable {
super.finalize();
}
}
"""
)
);
}

@Test
void hasSuperFinalizeInvocation() {
rewriteRun(
Expand Down
Loading