Migrate Spring Retry to Spring Resilience - #1057
Open
arnabnandy7 wants to merge 2 commits into
Open
Conversation
Signed-off-by: Arnab Nandy <arnab_nandy7@yahoo.com>
Signed-off-by: Arnab Nandy <arnab_nandy7@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
org.openrewrite.java.spring.framework.MigrateSpringRetryToResiliencerecipe tospring-framework-70.yml.org.springframework.retry:spring-retrydependency.RetryTemplate,RetryCallback,RetryListener,@EnableRetry, and@Retryableto their new built-in equivalents inorg.springframework.core.retry.*andorg.springframework.resilience.annotation.*.CleanUpRetryableTypeArgumentsto adjust parameterized type arguments, converting the 2-parameter signatureRetryable<R, E>(migrated fromRetryCallback) to the new 1-parameterRetryable<R>signature.MigrateSpringRetryToResilienceTest.java.What's your motivation?
Anything in particular you'd like reviewers to focus on?
CleanUpRetryableTypeArgumentsvisitor which correctly handles clearing out the secondary type parameter (E) of migrated generic references.Have you considered any alternatives or workarounds?
ChangeTypedo not automatically drop type arguments when changing to a class with a different type parameter count. A custom Java visitor was necessary to clean this up safely.RetryTemplate.builder()) and@Recovermethod refactoring to keep this upgrade path safe and mechanical.Checklist