Adds Baltics map#4614
Open
RickD004 wants to merge 2 commits into
Open
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughAdds the Baltics map with metadata, nation definitions, map assets, country records, English localization, and generated game-map registry entries. ChangesBaltics map
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@map-generator/assets/maps/baltics/info.json`:
- Around line 124-127: Correct the city name from “Liepaga” to “Liepaja” in
map-generator/assets/maps/baltics/info.json lines 124-127, then regenerate or
update resources/maps/baltics/manifest.json lines 270-273 so it matches the
corrected source data.
- Around line 149-152: Resolve the duplicate “Siauliai” entries by verifying
whether either map-generator/assets/maps/baltics/info.json entry at lines
149-152 or 296-299 represents a different city; rename it accordingly or remove
the duplicate. Regenerate or update resources/maps/baltics/manifest.json entries
at lines 109-112 and 295-298 to match the corrected source data.
- Around line 246-249: Remove the trailing space from the "Pustoshka " name in
map-generator/assets/maps/baltics/info.json:246-249, then update the
corresponding manifest entry in resources/maps/baltics/manifest.json:59-62 to
use the corrected "Pustoshka" value.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: f4f43317-2257-40d9-a183-7b2bdc57f4bf
⛔ Files ignored due to path filters (18)
map-generator/assets/maps/baltics/image.pngis excluded by!**/*.pngresources/flags/Courland Governorate.svgis excluded by!**/*.svgresources/flags/Duchy of Courland and Semigallia.svgis excluded by!**/*.svgresources/flags/Estonia (nordic).svgis excluded by!**/*.svgresources/flags/Grand Duchy of Finland.svgis excluded by!**/*.svgresources/flags/Grand Duchy of Lithuania.svgis excluded by!**/*.svgresources/flags/Ireland Green Harp.svgis excluded by!**/*.svgresources/flags/Kalmar Union.svgis excluded by!**/*.svgresources/flags/Mulgimaa.svgis excluded by!**/*.svgresources/flags/Noarootsi.svgis excluded by!**/*.svgresources/flags/Setomaa.svgis excluded by!**/*.svgresources/flags/Swedish Empire.svgis excluded by!**/*.svgresources/flags/Teutonic Order.svgis excluded by!**/*.svgresources/flags/Vorumaa.svgis excluded by!**/*.svgresources/flags/Votians.svgis excluded by!**/*.svgresources/maps/baltics/map.binis excluded by!**/*.binresources/maps/baltics/map16x.binis excluded by!**/*.binresources/maps/baltics/map4x.binis excluded by!**/*.bin
📒 Files selected for processing (6)
map-generator/assets/maps/baltics/info.jsonresources/countries.jsonresources/lang/en.jsonresources/maps/baltics/manifest.jsonresources/maps/baltics/thumbnail.webpsrc/core/game/Maps.gen.ts
github-project-automation
Bot
moved this from Triage
to Development
in OpenFront Release Management
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Adds Baltics map. Basic map for v33 just to have something simple since most maps have special shapes due to impassable terrain.
One mainland with detached "islands" to have multiple island players for interesting gameplay.
Regional European maps are also always popular.
36 nations with additional nations for a total of over +60
Please complete the following:
Please put your Discord username so you can be contacted if a bug or regression is found:
tri.star1011