Skip to content

Patch lifecycle to avoid interacting with project boards overly - #375

Merged
lilyminium merged 14 commits into
masterfrom
update-tokens-in-ci
Sep 12, 2024
Merged

Patch lifecycle to avoid interacting with project boards overly#375
lilyminium merged 14 commits into
masterfrom
update-tokens-in-ci

Conversation

@lilyminium

@lilyminium lilyminium commented Sep 10, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR patches lifecycle.py to give up on moving things between board columns and just submit the datasets. It's meant to be a temporary, easier to review fix than #377.

@lilyminium lilyminium added the test-label This is a test label to be added or removed automatically via CI. label Sep 11, 2024
@lilyminium lilyminium mentioned this pull request Sep 11, 2024
Merged
@lilyminium lilyminium added tracking test-label This is a test label to be added or removed automatically via CI. test-ci and removed test-label This is a test label to be added or removed automatically via CI. test-ci labels Sep 11, 2024
@openff-dangerbot openff-dangerbot added test-label This is a test label to be added or removed automatically via CI. and removed test-label This is a test label to be added or removed automatically via CI. labels Sep 11, 2024
@openff-dangerbot

openff-dangerbot commented Sep 11, 2024

Copy link
Copy Markdown
Contributor

This is a test comment from running CI. Please ignore

@openff-dangerbot openff-dangerbot added test-label This is a test label to be added or removed automatically via CI. and removed test-label This is a test label to be added or removed automatically via CI. labels Sep 11, 2024
@openff-dangerbot

openff-dangerbot commented Sep 11, 2024

Copy link
Copy Markdown
Contributor

This is a test comment from running CI. Please ignore

@openff-dangerbot openff-dangerbot added test-label This is a test label to be added or removed automatically via CI. and removed test-label This is a test label to be added or removed automatically via CI. labels Sep 11, 2024
@openff-dangerbot

openff-dangerbot commented Sep 11, 2024

Copy link
Copy Markdown
Contributor

This is a test comment from running CI. Please ignore

@lilyminium

lilyminium commented Sep 11, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Apologies for the messy dangerbot actions -- I refactored lifecycle.py to use GraphQL, but then split that out into a separate PR #377. This is now just a bandaid patch to try to get datasets submitted before #377 can get merged. We will have to manually move the card to the Error cycling to get that to trigger, I believe.

@lilyminium

lilyminium commented Sep 11, 2024

Copy link
Copy Markdown
Contributor Author

The passing CI run was triggered manually here: https://github.com/openforcefield/qca-dataset-submission/actions/runs/10807416097/job/29978159402

@lilyminium lilyminium changed the title Update token in lifecycle submission Patch lifecycle to avoid interacting with project boards overly Sep 11, 2024
@lilyminium

lilyminium commented Sep 11, 2024

Copy link
Copy Markdown
Contributor Author

I think this is now ready for review.

@lilyminium
lilyminium requested a review from j-wags September 11, 2024 08:01
@lilyminium
lilyminium marked this pull request as ready for review September 11, 2024 08:02
This was referenced Sep 11, 2024
Draft
Merged
Merged
j-wags
j-wags approved these changes Sep 12, 2024
View reviewed changes

@j-wags j-wags left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for updating this and apologies that this held up submissions!

@lilyminium

lilyminium commented Sep 12, 2024

Copy link
Copy Markdown
Contributor Author

Thanks for the review @j-wags!

@lilyminium
lilyminium merged commit 62a8290 into master Sep 12, 2024
@lilyminium
lilyminium deleted the update-tokens-in-ci branch September 12, 2024 13:35
@lilyminium lilyminium mentioned this pull request Sep 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@j-wags j-wags j-wags approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lilyminium @openff-dangerbot @j-wags