Skip to content

Update of-watchdog to 0.12.1 - #318

Open
welteki wants to merge 1 commit into
openfaas:masterfrom
welteki:update-of-watchdog
Open

welteki wants to merge 1 commit into
openfaas:masterfrom
welteki:update-of-watchdog

Conversation

@welteki

@welteki welteki commented Sep 24, 2026 •

Copy link
Copy Markdown
Member

Description

Update of-watchdog from 0.11.6 to 0.12.1 in the node18, node20, node22, node24, node25, java11, java11-vert-x and java17 templates. Classic-watchdog templates are unchanged.

Motivation and Context

  • I have raised an issue to propose this change (required)

Support OAuth/OIDC login for functions using the latest of-watchdog release.

Which issue(s) this PR fixes

None.

How Has This Been Tested?

Built functions from all five Node.js templates with faas-cli build on Linux amd64 using faas-cli 0.18.13 and Docker 29.7.2. Ran each image locally and invoked it over HTTP, confirming HTTP 200, the expected response and watchdog version 0.12.1 in the logs.

Attempted builds for all three Java templates. These were blocked by pre-existing missing OpenJDK base-image tags: openjdk:11-jre-slim for java11 and java11-vert-x, and openjdk:17-jdk-slim for java17. Only the Node.js templates could be build-verified. This should be fixed in a separate PR.

Verified that all eight of-watchdog references were updated, all three classic-watchdog Dockerfiles were unchanged, and git diff --check passed.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Version change (see: Impact to existing users)

Impact to existing users

Functions rebuilt with these templates will use of-watchdog 0.12.1 and can enable OAuth/OIDC login. Existing deployed images are unaffected. The Node.js smoke tests passed; Java runtime compatibility could not be verified because of the missing base images.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Use the latest of-watchdog release with OAuth/OIDC support in all Node.js and Java templates. Leave classic-watchdog templates unchanged.

Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
@reviewfn

reviewfn Bot commented Sep 24, 2026

Copy link
Copy Markdown

AI Pull Request Overview

Disclaimer: This review was generated by automated AI and may contain errors. Do not trust its outputs without human verification.

Summary

  • Updates of-watchdog from 0.11.6 to 0.12.1 across the scoped Node.js and Java templates.
  • The scoped diff only changes Dockerfile watchdog image tags.
  • All eight changed Dockerfiles now reference the same ghcr.io/openfaas/of-watchdog:0.12.1 tag.
  • Classic watchdog templates are outside the scoped diff and are not reviewed here.
  • No concrete correctness, compatibility, or security issue was identified in the scoped changes.

Approval rating (1-10)

9/10. The change is small, consistent, and limited to the intended watchdog image version update.

Summary per file

Summary per file
File path Summary
template/java11-vert-x/Dockerfile Updates of-watchdog image tag to 0.12.1.
template/java11/Dockerfile Updates of-watchdog image tag to 0.12.1.
template/java17/Dockerfile Updates of-watchdog image tag to 0.12.1.
template/node18/Dockerfile Updates of-watchdog image tag to 0.12.1.
template/node20/Dockerfile Updates of-watchdog image tag to 0.12.1.
template/node22/Dockerfile Updates of-watchdog image tag to 0.12.1.
template/node24/Dockerfile Updates of-watchdog image tag to 0.12.1.
template/node25/Dockerfile Updates of-watchdog image tag to 0.12.1.

Overall Assessment

The pull request is narrowly scoped and internally consistent. Each changed template updates the same of-watchdog image reference from 0.11.6 to 0.12.1, without changing Dockerfile structure, runtime base images, build stages, environment variables, or handler behavior. I did not identify a blocking issue in the scoped diff.

Detailed Review

Detailed Review

No blocking findings.

The changed Dockerfiles all update only the ghcr.io/openfaas/of-watchdog tag. The version change is applied consistently across the scoped Java and Node.js templates, and there is no partial update within the reviewed files. Because the runtime stages and copy paths remain unchanged, the templates should continue to copy /fwatchdog from the watchdog stage into /usr/bin/fwatchdog as before.

AI agent details.

Agent processing time: 44.806s
Environment preparation time: 3.105s
Total time from webhook: 50.474s

@welteki
welteki marked this pull request as ready for review September 24, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant