Conversation
Use the latest of-watchdog release with OAuth/OIDC support in all Node.js and Java templates. Leave classic-watchdog templates unchanged. Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
AI Pull Request OverviewDisclaimer: This review was generated by automated AI and may contain errors. Do not trust its outputs without human verification. Summary
Approval rating (1-10)9/10. The change is small, consistent, and limited to the intended watchdog image version update. Summary per fileSummary per file
Overall AssessmentThe pull request is narrowly scoped and internally consistent. Each changed template updates the same Detailed ReviewDetailed ReviewNo blocking findings. The changed Dockerfiles all update only the AI agent details. |
Description
Update of-watchdog from 0.11.6 to 0.12.1 in the
node18,node20,node22,node24,node25,java11,java11-vert-xandjava17templates. Classic-watchdog templates are unchanged.Motivation and Context
Support OAuth/OIDC login for functions using the latest of-watchdog release.
Which issue(s) this PR fixes
None.
How Has This Been Tested?
Built functions from all five Node.js templates with
faas-cli buildon Linux amd64 using faas-cli 0.18.13 and Docker 29.7.2. Ran each image locally and invoked it over HTTP, confirming HTTP 200, the expected response and watchdog version 0.12.1 in the logs.Attempted builds for all three Java templates. These were blocked by pre-existing missing OpenJDK base-image tags:
openjdk:11-jre-slimforjava11andjava11-vert-x, andopenjdk:17-jdk-slimforjava17. Only the Node.js templates could be build-verified. This should be fixed in a separate PR.Verified that all eight of-watchdog references were updated, all three classic-watchdog Dockerfiles were unchanged, and
git diff --checkpassed.Types of changes
Impact to existing users
Functions rebuilt with these templates will use of-watchdog 0.12.1 and can enable OAuth/OIDC login. Existing deployed images are unaffected. The Node.js smoke tests passed; Java runtime compatibility could not be verified because of the missing base images.
Checklist:
git commit -s