Conversation
AaronGilMartinez
requested changes
Aug 28, 2026
Comment on lines
+25
to
+40
| document | ||
| .querySelectorAll('[class*="offcanvas-"][role]') | ||
| .forEach(function initializeStaticOffcanvasRole(offcanvas) { | ||
| if (staticOffcanvasRoles.has(offcanvas)) { | ||
| return; | ||
| } | ||
|
|
||
| staticOffcanvasRoles.set(offcanvas, offcanvas.getAttribute('role')); | ||
| // Bootstrap removes its dialog role when the offcanvas closes. | ||
| offcanvas.addEventListener( | ||
| 'hidden.bs.offcanvas', | ||
| function restoreStaticOffcanvasRole() { | ||
| offcanvas.setAttribute('role', staticOffcanvasRoles.get(offcanvas)); | ||
| } | ||
| ); | ||
| }); |
Contributor
There was a problem hiding this comment.
The new WeakMap stores the current role from the live DOM, which can already be dialog if this behavior attaches after Bootstrap has opened the offcanvas. In that case we restore the wrong role on close. Please cache the intended static role from an author controlled source instead, for example a data-* attribute set in Twig, and restore from that value.
Contributor
Author
There was a problem hiding this comment.
fixed, indeed. thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira issue(s):