Skip to content

[Backport] fix: only auto-submit SSO registration form when provider returns an email#38887

Open
ayesha-waris wants to merge 1 commit into
openedx:release/verawoodfrom
ayesha-waris:ayesha/backport-38860-verawood
Open

[Backport] fix: only auto-submit SSO registration form when provider returns an email#38887
ayesha-waris wants to merge 1 commit into
openedx:release/verawoodfrom
ayesha-waris:ayesha/backport-38860-verawood

Conversation

@ayesha-waris

Copy link
Copy Markdown
Contributor

Backport of #38860 to the release/verawood branch.

Description

When a third-party auth provider has "skip registration form" enabled, the authn MFE context set autoSubmitRegForm=True unconditionally. Providers such as Facebook (email permission denied) or Microsoft Entra ID can complete authentication without returning an email claim; auto-submitting the registration form in that case silently fails client-side validation and leaves the learner stuck on a partially-filled form with no explanation.

This change gates the auto-submit on the provider actually returning an email so the learner falls back to the normal registration form and can fill in what is missing.

Backport details

…email

When a third-party auth provider has "skip registration form" enabled, the
authn MFE context set autoSubmitRegForm=True unconditionally. Providers such
as Facebook (email permission denied) or Microsoft Entra ID can complete
authentication without returning an email claim; auto-submitting the
registration form in that case silently fails client-side validation and
leaves the learner stuck on a partially-filled form with no explanation.

Gate the auto-submit on the provider actually returning an email so the
learner falls back to the normal registration form and can fill in what is
missing.

Fixes: openedx#38780
@ayesha-waris ayesha-waris requested a review from a team as a code owner July 14, 2026 13:20
@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Jul 14, 2026
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @ayesha-waris!

This repository is currently maintained by @openedx/wg-maintenance-openedx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@mphilbrick211 mphilbrick211 moved this from Needs Triage to In Eng Review in Contributions Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: In Eng Review

Development

Successfully merging this pull request may close these issues.

4 participants