reject non-finite decimal64 values on unmarshal - #1098
Open
nabhan06 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sanitizeJSON and stringToKeyType parse a decimal64 leaf/key from an untrusted JSON string with strconv.ParseFloat, which happily accepts NaN, Inf and Infinity, so Unmarshal stores a non-finite float64 for a leaf whose schema can never hold one. That value then cannot be round-tripped back out since encoding/json rejects NaN and Inf, and a stored NaN quietly breaks equality and diffing. Reject a non-finite result at both parse sites so the value is turned away where it enters rather than surfacing much later.